1885051 - [wpt-sync] Sync PR 45069 - Don't run button popover code when default is handled

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45069 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45069
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Don't run button popover code when default is handled

This patch prevents the popovertarget code in HTMLFormControlElement
from running when the \<button> already handled a DOMActivate event for
type=reset or type=submit.

Fixed: 329118508
Change-Id: Ic1f82cd3b72a7d3a281f5cf884a0c470e87a8ffb

Reviewed-on: https://chromium-review.googlesource.com/5368578
WPT-Export-Revision: df65f2c3930a114ce43424eefebe61b15ded3ae7

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3316f3b3dfc5be9f8307fce6b27b4a232c53c4a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e13e35ff49035338adb8f08f7d87b30a4c96b92a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popovers/button-type-reset-popovertarget.tentative.html [wpt.fyi]
  • Button type=reset and type=submit should not run popover algorithms when in a form.: FAIL (Chrome: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9204b0c03c62
[wpt PR 45069] - Don't run button popover code when default is handled, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b92c9aad8907
[wpt PR 45069] - Update wpt metadata, a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9204b0c03c62
https://hg.mozilla.org/mozilla-central/rev/b92c9aad8907