1885333 - [wpt-sync] Sync PR 45105 - Make trailing space hanging behavior depend on the item's style

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45105 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45105
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

Make trailing space hanging behavior depend on the item's style

The CL https://crrev.com/c/4881393 changed the hanging space behavior
to not depend on text-align, and it updated the implementation to
match the spec text. However, that patch had a misunderstanding of the
spec that made each line's hanging space behavior depend on its block
container's styles, rather than on each space's inline item styles.
That caused incompatibilities with other browsers.

This patch makes this behavior dependent on the inline item styles,
thus fixing the main source of incompatibilities.

The spec text is not yet fully clear on the behavior of some edge
cases, which is why the WPT tests this CL adds are marked as
tentative. See https://github.com/w3c/csswg-drafts/issues/9724 for the
CSSWG issue discussing this.

Bug: 40944859
Change-Id: Ib93d0ffe41a8c538c8a4c9a13838bc304c26b30e

Reviewed-on: https://chromium-review.googlesource.com/5147580
WPT-Export-Revision: 06cf813f5322ff92cb831b53efcc207dacdb30e9

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=28efb7fc09009ed98e65824acf501c06c4b35116

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 1
FAIL: 2

Chrome

FAIL: 3

Safari

FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-text/white-space/hanging-whitespace-002.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-text/white-space/hanging-whitespace-003.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/573253807a24
[wpt PR 45105] - Make trailing space hanging behavior depend on the item's style, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2d1df85e01f0
[wpt PR 45105] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/573253807a24
https://hg.mozilla.org/mozilla-central/rev/2d1df85e01f0