Closed Bug 1885463 Opened 2 years ago Closed 1 year ago

[wpt-sync] Sync PR 45117 - Un-duplicate span IDs in comp_label.html

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45117 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45117
Details from upstream follow.

Dan Clark <daniec@microsoft.com> wrote:

Un-duplicate span IDs in comp_label.html

In the test case "button's hidden referenced name (visibility:hidden) with hidden aria-labelledby traversal falls back to aria-label", the referenced id span4 is a duplicate ID of an element from the prior test case. So aria-labeledby ends up pointing to the one that comes first in document order. This will lead to a wrong result because the span4 in the previous test is hidden, while the span4 in this test is not.

Un-duplicate the span IDs so that we're testing the right scenario.

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 142 subtests

Status Summary

Firefox

OK : 1
PASS: 136
FAIL: 6

Chrome

OK : 1
PASS: 132
FAIL: 10

Safari

OK : 1
PASS: 130
FAIL: 12

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /accname/name/comp_label.html [wpt.fyi]
    • aria-label undefined on img w/ alt: FAIL (Chrome: FAIL, Safari: FAIL)
    • aria-label undefined on img w/o alt: FAIL (Chrome: FAIL, Safari: FAIL)
    • aria-label undefined on img w/ empty alt: FAIL (Chrome: FAIL, Safari: FAIL)
    • aria-label undefined on img w/o alt but w/ title: FAIL (Chrome: FAIL, Safari: FAIL)
    • aria-label undefined on img w/ empty alt but w/ title: FAIL (Chrome: FAIL, Safari: FAIL)
    • Hidden button's label should be the empty string: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/55488b790694 [wpt PR 45117] - Un-duplicate span IDs in comp_label.html, a=testonly https://hg.mozilla.org/integration/autoland/rev/36ea7304aae4 [wpt PR 45117] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/55488b790694
https://hg.mozilla.org/mozilla-central/rev/36ea7304aae4

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.