Closed
Bug 1885542
Opened 7 months ago
Closed 5 months ago
"WheelScrollAction.performOneWheelScroll" doesn't update key input state
Categories
(Remote Protocol :: WebDriver BiDi, defect, P2)
Remote Protocol
WebDriver BiDi
Tracking
(firefox127 fixed)
RESOLVED
FIXED
127 Branch
| Tracking | Status | |
|---|---|---|
| firefox127 | --- | fixed |
People
(Reporter: whimboo, Assigned: Sasha)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m11], [wptsync upstream][webdriver:relnote])
Attachments
(2 files)
Originally filed as: https://github.com/puppeteer/puppeteer/issues/12093
As described we are not correctly updating the wheel action with the global key state and as such a previously set modifier key is not included when synthesizing the wheel scroll event through EventUtils:
First we need to forward the state from WheelScrollAction.dispatch to WheelScrollAction.performOneWheelScroll, and there the event data needs to be updated with the global key state as done here for multitouch event:
|
Reporter | |
Updated•7 months ago
|
Points: --- → 3
Priority: -- → P2
Whiteboard: [webdriver:m11]
|
||
Comment 1•6 months ago
|
||
The severity field is not set for this bug.
:whimboo, could you have a look please?
For more information, please visit BugBot documentation.
Flags: needinfo?(hskupin)
|
|
Reporter | |
Updated•6 months ago
|
Severity: -- → S3
Flags: needinfo?(hskupin)
|
Assignee | |
Updated•5 months ago
|
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•5 months ago
|
||
|
|
Assignee | |
Comment 3•5 months ago
|
||
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27bca281398d
Set modifier properties based on whether any corresponding keys are pressed to wheel event. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/483c12f06e38
[wdspec] Add tests for wheel event with control key pressed. r=webdriver-reviewers,whimboo
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46093 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m11] → [webdriver:m11], [wptsync upstream]
Upstream PR was closed without merging
|
||
Comment 7•5 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/27bca281398d
https://hg.mozilla.org/mozilla-central/rev/483c12f06e38
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox127:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Upstream PR merged by moz-wptsync-bot
|
|
Reporter | |
Updated•4 months ago
|
Whiteboard: [webdriver:m11], [wptsync upstream] → [webdriver:m11], [wptsync upstream][webdriver:relnote]
You need to log in
before you can comment on or make changes to this bug.
Description
•