1885542 - "WheelScrollAction.performOneWheelScroll" doesn't update key input state

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Originally filed as: https://github.com/puppeteer/puppeteer/issues/12093

As described we are not correctly updating the wheel action with the global key state and as such a previously set modifier key is not included when synthesizing the wheel scroll event through EventUtils:

https://searchfox.org/mozilla-central/rev/288d6e88a58467357a282a67108d36ccb0315a2a/remote/shared/webdriver/Actions.sys.mjs#1337-1365

First we need to forward the state from WheelScrollAction.dispatch to WheelScrollAction.performOneWheelScroll, and there the event data needs to be updated with the global key state as done here for multitouch event:

https://searchfox.org/mozilla-central/rev/288d6e88a58467357a282a67108d36ccb0315a2a/remote/shared/webdriver/Actions.sys.mjs#2291-2301

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1885542 - Set modifier properties based on whether any corresponding keys are pressed to wheel event.

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1885542 - [wdspec] Add tests for wheel event with control key pressed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27bca281398d
Set modifier properties based on whether any corresponding keys are pressed to wheel event. r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/483c12f06e38
[wdspec] Add tests for wheel event with control key pressed. r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46093 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/27bca281398d
https://hg.mozilla.org/mozilla-central/rev/483c12f06e38

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot