1885583 - [Menu Redesign] Add BottomSheetDialog.dismiss() when onRequestDismiss is called

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Roger Yang [:royang]]

A predictive back is when the user swipes left -> right or right -> left from the edge of the screen, it will dismiss/close the menu.

Design here: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-82006&mode=design&t=lu0I4xY5gKXPXbUz-4

Comment 1

[Mihai Adrian Carare [:mcarare]]

Does this involve opting-in to predictive back entirely or at an activity level?

Comment 2

[Aarjav [:aarjav]]

The predictive back behaviour is different for the sub-menu.

• If a user does predictive back in the sub-menu, it takes them to the main menu. It does not close the menu component.
• If a user does predictive back on the main menu, it closes the menu component.

Should that be a separate ticket?

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Possible resources

https://developer.android.com/reference/kotlin/androidx/activity/compose/package-summary#backhandler
https://developer.android.com/reference/kotlin/androidx/activity/compose/package-summary#PredictiveBackHandler(kotlin.Boolean,kotlin.coroutines.SuspendFunction1)

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Aarjav [:aarjav] from comment #2)

The predictive back behaviour is different for the sub-menu.

• If a user does predictive back in the sub-menu, it takes them to the main menu. It does not close the menu component.
• If a user does predictive back on the main menu, it closes the menu component.

Should that be a separate ticket?

I think this can both be resolved in this ticket depending on the assignee. If not, we can always file a follow up for anything that is not covered.

Comment 5

[Iorga Gabriel]

Attachment: Bug 1885583 - [Menu Redesign]Add BottomSheetDialog.dismiss() when onRequestDismiss is called.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Isn't this functionality already working?:

• back in a submenu should return to menu
• back in menu should close it

Is the default behavior for when swiping horizontally from the edge of the screen - this gesture is seen as a back press.

The predictive back gesture framework aims to show an animated preview of where the user would get when pressing back - https://developer.android.com/guide/navigation/custom-back/predictive-back-gesture
Not sure we need that for the menu/submenu.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c344778a17f
[Menu Redesign]Add BottomSheetDialog.dismiss() when onRequestDismiss is called. r=android-reviewers,gl

Comment 8

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/0c344778a17f

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Re-purposed this bug to handle dismissing the bottom sheet when onRequestDismiss in the bottom sheet handle is called.