1885613 - [Menu Redesign] Implement Save sub menu

Status: RESOLVED FIXED

(Fenix :: Toolbar, task)

Description

[Roger Yang [:royang]]

Implement the Save sub menus.

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9746-49734&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885613 - Part 1: Add strings for Save submenu

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885613 - Part 2: Implement a submenu header component

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9940-23888&mode=dev

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885613 - Part 3: Implement the Save submenu component

• This adds the Save submenu and their respective menu items as a placeholder with a no-op click handling.
  Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=9751-59203&mode=design&t=PIWrTa1T4bNExHGp-4

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885613 - Part 4: Implement navigation from the main menu to the save submenu

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885613 - Part 5: Implement Save as PDF menu functionality

• Calls the Save to PDF use case when the "Save as PDF" menu item is clicked in the Save submenu
• Follows https://searchfox.org/mozilla-central/rev/863aef60f9fa1536884252ad90cad1d8ee9d8a41/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/share/ShareController.kt#159-162

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03760c10370c
Part 1: Add strings for Save submenu r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/74b3ea621cc9
Part 2: Implement a submenu header component r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/e08ec95047c4
Part 3: Implement the Save submenu component r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/881e56e2ac19
Part 4: Implement navigation from the main menu to the save submenu r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/12fbc97c44d2
Part 5: Implement Save as PDF menu functionality r=android-reviewers,ohall

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/03760c10370c
https://hg.mozilla.org/mozilla-central/rev/74b3ea621cc9
https://hg.mozilla.org/mozilla-central/rev/e08ec95047c4
https://hg.mozilla.org/mozilla-central/rev/881e56e2ac19
https://hg.mozilla.org/mozilla-central/rev/12fbc97c44d2