1885625 - [Menu Redesign] Implement Reader View states

Status: RESOLVED FIXED

(Fenix :: Toolbar, task, P1)

Description

[Roger Yang [:royang]]

Implement reader view states

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66348&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 1

[Sanchaai [:sanchaai]]

Attachment: WIP: Bug 1885625 - Implement Reader View states

Implement reader view states for menu redesign.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66348&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 2

[Sanchaai [:sanchaai]]

Attachment: Bug 1885625 - Implement Reader View states. r=gl

Implement the functionality for turning Reader View on/off in the menu redesign.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66348&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 3

[Sanchaai [:sanchaai]]

Attachment: Bug 1885625 - Implement Reader View states. r=gl

Implement the functionality for turning Reader View on/off in the menu redesign. Includes unit tests for turning Reader View on/off.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66348&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 4

[Sanchaai [:sanchaai]]

Attachment: Bug 1885625 - Implement Reader View states. r=gl

Implement the functionality for turning Reader View on/off in the menu redesign.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66348&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26b5a5d36f80
Implement Reader View states. r=gl,android-reviewers

Comment 6

[tszentpeteri]

Backed out for causing linting failures related to MenuDialogMiddlewareTest.kt

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-12T02:40:08.991Z] > Configure project :lib-crash
[task 2024-07-12T02:40:08.991Z] Requires glean_parser 14.0
[task 2024-07-12T02:40:09.591Z] 
[task 2024-07-12T02:40:09.591Z] > Task :publicsuffixlist:checkKotlinGradlePluginConfigurationErrors
[task 2024-07-12T02:40:11.891Z] > Task :publicsuffixlist:pluginDescriptors
[task 2024-07-12T02:40:11.891Z] > Task :publicsuffixlist:processResources
[task 2024-07-12T02:40:13.091Z] > Task :publicsuffixlist:compileKotlin
[task 2024-07-12T02:40:13.091Z] > Task :publicsuffixlist:compileJava NO-SOURCE
[task 2024-07-12T02:40:13.091Z] > Task :publicsuffixlist:classes
[task 2024-07-12T02:40:13.091Z] > Task :publicsuffixlist:jar
[task 2024-07-12T02:40:14.791Z] 
[task 2024-07-12T02:40:14.791Z] > Configure project :service-nimbus
[task 2024-07-12T02:40:14.791Z] Requires glean_parser 14.0
[task 2024-07-12T02:40:20.291Z] 
[task 2024-07-12T02:40:20.291Z] > Task :listRepositories
[task 2024-07-12T02:40:20.291Z] Repositories:
[task 2024-07-12T02:40:20.291Z] Name: maven; url: file:/builds/worker/fetches/geckoview
[task 2024-07-12T02:40:20.291Z] Name: maven2; url: file:/builds/worker/fetches/android-gradle-dependencies/mozilla/
[task 2024-07-12T02:40:20.291Z] Name: maven3; url: file:/builds/worker/fetches/android-gradle-dependencies/google/
[task 2024-07-12T02:40:20.291Z] Name: maven4; url: file:/builds/worker/fetches/android-gradle-dependencies/central/
[task 2024-07-12T02:40:20.291Z] Name: maven5; url: file:/builds/worker/fetches/android-gradle-dependencies/gradle-plugins/
[task 2024-07-12T02:40:20.291Z] Name: maven6; url: file:/builds/worker/fetches/android-gradle-dependencies/plugins.gradle.org/m2/
[task 2024-07-12T02:40:20.291Z] Name: maven7; url: file:/builds/worker/checkouts/gecko/obj-arm-unknown-linux-androideabi/gradle/maven
[task 2024-07-12T02:40:29.991Z] 
[task 2024-07-12T02:40:29.991Z] > Task :ktlint
[task 2024-07-12T02:40:29.991Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/menu/MenuDialogMiddlewareTest.kt:7:1: Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end (standard:import-ordering)
[task 2024-07-12T02:40:29.991Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/menu/MenuDialogMiddlewareTest.kt:9:1: Duplicate 'import kotlinx.coroutines.runBlocking' found (standard:import-ordering)
[task 2024-07-12T02:40:29.991Z] /builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/components/menu/MenuDialogMiddlewareTest.kt:9:1: Unused import (standard:no-unused-imports)
[task 2024-07-12T02:40:31.091Z] 
[task 2024-07-12T02:40:31.091Z] Summary error count (descending) by rule:
[task 2024-07-12T02:40:31.091Z]   standard:import-ordering: 2
[task 2024-07-12T02:40:31.091Z]   standard:no-unused-imports: 1
[task 2024-07-12T02:40:31.091Z] 
[task 2024-07-12T02:40:31.091Z] > Task :ktlint FAILED
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] FAILURE: Build failed with an exception.
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] * What went wrong:
[task 2024-07-12T02:40:31.191Z] Execution failed for task ':ktlint'.
[task 2024-07-12T02:40:31.191Z] > Process 'command '/builds/worker/fetches/jdk/jdk-17.0.11+9/bin/java'' finished with non-zero exit value 1
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] * Try:
[task 2024-07-12T02:40:31.191Z] > Run with --stacktrace option to get the stack trace.
[task 2024-07-12T02:40:31.191Z] > Run with --info or --debug option to get more log output.
[task 2024-07-12T02:40:31.191Z] > Run with --scan to get full insights.
[task 2024-07-12T02:40:31.191Z] > Get more help at https://help.gradle.org.
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] For more on this, please refer to https://docs.gradle.org/8.7/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
[task 2024-07-12T02:40:31.191Z] 
[task 2024-07-12T02:40:31.191Z] BUILD FAILED in 1m 41s
[task 2024-07-12T02:40:31.191Z] 27 actionable tasks: 27 executed
[taskcluster 2024-07-12 02:40:32.062Z] === Task Finished ===
[taskcluster 2024-07-12 02:40:32.062Z] Unsuccessful task run with exit code: 1 completed in 251.534 seconds

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/018db37bd8a3
Implement Reader View states. r=gl,android-reviewers

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/018db37bd8a3