1885628 - [Menu Redesign] Implement Bookmark states

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task)

Description

[Roger Yang [:royang]]

Implement bookmark states

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66353&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885628 - Part 1: Fetch the isBookmarked state when the store is initialized

• Refactors the MenuStore to contain a BrowserMenuState that is only populated when a browser tab is selected.
  This is to anticipate that we will handle multiple different types of accesspoint such as Home, Browser and Custom Tab.
  Each accesspoint will have its only state so that we will only ever fetch what is necessary when the MenuStore is initialized.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885628 - Part 2: Display the active bookmark menu state when the selected tab is bookmarked

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66353&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885628 - Part 3: Refactor `getProperUrl` into an extension function `TabSessionState.getUrl`

• This refactors getProperUrl that was introduced in https://github.com/mozilla-mobile/fenix/pull/16181 into an extension function that lives in AC.
• This function will fetch the correct URL to be used when handling features such as bookmarks or share regardless of what mode the browser might be in (e.g. Reader mode).

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885628 - Part 4: Implement adding a bookmark in the menu redesign

• This adds the ability tobookmark the selected tab when the "Bookmark page" menu item is clicked.

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885628 - Part 5: Implement navigation to editing bookmark of the selected tab

• Adds guid to MenuState and refactors the existing bookmark states into BookmarkState within BrowserMenuState.
• guid is used for tracking the bookmark to be edited when navigating to edit bookmark.
• Adds the ability to navigate to the Edit Bookmark fragment when the "Edit" button in the "Bookmarked" menu is clicked.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87f0521f8f14
Part 1: Fetch the isBookmarked state when the store is initialized r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/0bf21e9bab47
Part 2: Display the active bookmark menu state when the selected tab is bookmarked r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/4f196d1b7be9
Part 3: Refactor `getProperUrl` into an extension function `TabSessionState.getUrl` r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/41d75b810dc7
Part 4: Implement adding a bookmark in the menu redesign r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/63983f5e4555
Part 5: Implement navigation to editing bookmark of the selected tab r=android-reviewers,matt-tighe

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/87f0521f8f14
https://hg.mozilla.org/mozilla-central/rev/0bf21e9bab47
https://hg.mozilla.org/mozilla-central/rev/4f196d1b7be9
https://hg.mozilla.org/mozilla-central/rev/41d75b810dc7
https://hg.mozilla.org/mozilla-central/rev/63983f5e4555