Closed Bug 1885630 Opened 11 months ago Closed 8 months ago

[Menu Redesign] Implement Shortcut states

Categories

(Fenix :: Toolbar, task, P1)

Product:
Fenix
Component:
Toolbar
Platform:
All
Android
Type:
task

Tracking

(firefox129 fixed)

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: royang, Assigned: sanchaai)

References

Details

(Whiteboard: [fxdroid])

Attachments

(4 files, 3 obsolete files)

Bug 1885630 - Part 1: Implement the addition of shortcuts. r=gl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885630 - Part 2: Implement menu UI change when site is pinned. r=gl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885630 - Part 3: Implement the removal of shortcuts. r=gl
48 bytes, text/x-phabricator-request
Details | Review
Bug 1885630 - Part 4: Implement blocking of shortcut additions when max limit reached. r=gl
48 bytes, text/x-phabricator-request
Details | Review
Summary: Implement Shortcut states → [Menu Redesign] Implement Shortcut states
Blocks: menu-redesign
Whiteboard: [fxdroid]
Severity: -- → S2
Severity: S2 → S3
Severity: S3 → N/A
Assignee: nobody → smathiyarasan
Status: NEW → ASSIGNED
Attachment #9401425 - Attachment description: Bug 1885630 - Part 1: Implement the addition of shortcuts → Bug 1885630 - Part 1: Implement the addition of shortcuts. r=gl

Change save menu UI so that the shortcuts menu item displays "Remove from shortcuts" when a site is pinned, and "Add to shortcuts" otherwise.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66352&mode=design&t=s2P4UpMXAhoVojlM-4

Attachment #9401456 - Attachment is obsolete: true

Change save menu UI so that the shortcuts menu item displays "Remove from shortcuts" when a site is pinned, and "Add to shortcuts" otherwise.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66352&mode=design&t=s2P4UpMXAhoVojlM-4

Attachment #9401490 - Attachment is obsolete: true
Attachment #9401456 - Attachment is obsolete: false

Implement the functionality of removing a site frp, the shortcuts screen on the homepage. Includes unit tests for removing shortcuts as well.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66352&mode=design&t=s2P4UpMXAhoVojlM-4

Attachment #9401510 - Attachment description: Bug 1885630 - Part 1: Implement the removal of shortcuts. r=gl → Bug 1885630 - Part 3: Implement the removal of shortcuts. r=gl

Change behaviour of adding shortcuts such that sites are not added when the maximum top sites limit is reached.

Figma: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=10858-66352&mode=design&t=s2P4UpMXAhoVojlM-4

Attachment #9400951 - Attachment is obsolete: true
Blocks: menu-redesign-save-submenu
No longer blocks: menu-redesign-tools-submenu
Attachment #9401729 - Attachment is obsolete: true
Priority: -- → P1
Blocks: 1904604
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b0971b034bd6 Part 1: Implement the addition of shortcuts. r=android-reviewers,gl https://hg.mozilla.org/integration/autoland/rev/083acbcf1f87 Part 2: Implement menu UI change when site is pinned. r=android-reviewers,gl
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3ed27cf66e0d Part 3: Implement the removal of shortcuts. r=gl,android-reviewers https://hg.mozilla.org/integration/autoland/rev/4dffacda4bd7 Part 4: Implement blocking of shortcut additions when max limit reached. r=gl,android-reviewers
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: