1885647 - [Menu Redesign] Implement Extensions menu and sub menu

Status: RESOLVED FIXED

(Fenix :: WebExtensions, task, P3)

Description

[Roger Yang [:royang]]

Implement the extensions menu and it's sub menus
This includes implementing the menu and the sub menu so we display the installed extensions

This DOES NOT include states, onboarding, recommendations

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=11203-151061&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 1: Add strings for the Extensions submenu

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=11203-151061&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 2: Display an Icon in the `afterListAction` in TextListItem if an `afterIconPainter` is provided

• In https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=11273-133792&mode=dev, we want to
  be able to display a TextListItem where the after list action is just an Icon instead of a IconButton. We also need the
  ability to customize the tint of the icon in TextListItem
• Add iconTint parameter to TextListItem to customize the tint of the icon.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 3: Implement a placeholder Extensions submenu component

Design: https://www.figma.com/file/RFz9fYtotQCQuinwcZujZt/Menu-Redesign?type=design&node-id=11203-151061&mode=design&t=s2P4UpMXAhoVojlM-4

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 4: Implement navigation to the Extensions submenu

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 5: Implement navigation for the "Manage extensions" menu item

• Navigates to the AddonsManagementFragment when the "Manage extensions" menu item is clicked in the Extensions submenu

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1885647 - Part 6: Implement navigation for the "Discover more extensions" menu item

• Navigates to the AMO page when the "Discover more extensions" menu item is clicked in the Extensions submenu
• Follows https://searchfox.org/mozilla-central/rev/f8a85c3ed2057e5aa735ad8d300cfbdfd96a7bad/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt#247

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc2e6c2ef31d
Part 1: Add strings for the Extensions submenu r=android-reviewers,harrisono
https://hg.mozilla.org/integration/autoland/rev/134c61b7444d
Part 2: Display an Icon in the `afterListAction` in TextListItem if an `afterIconPainter` is provided r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/479ebd5acec9
Part 3: Implement a placeholder Extensions submenu component r=android-reviewers,skhan
https://hg.mozilla.org/integration/autoland/rev/0cb558d664ed
Part 4: Implement navigation to the Extensions submenu r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/882376e5e9ae
Part 5: Implement navigation for the "Manage extensions" menu item r=android-reviewers,matt-tighe

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bc2e6c2ef31d
https://hg.mozilla.org/mozilla-central/rev/134c61b7444d
https://hg.mozilla.org/mozilla-central/rev/479ebd5acec9
https://hg.mozilla.org/mozilla-central/rev/0cb558d664ed
https://hg.mozilla.org/mozilla-central/rev/882376e5e9ae

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4fe46ffc85
Part 6: Implement navigation for the "Discover more extensions" menu item r=android-reviewers,amejiamarmol,willdurand

Comment 10

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/8a4fe46ffc85