Closed Bug 1885692 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45143 - Revert "View-transitions should only be allowed when page is visible"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45143 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45143
Details from upstream follow.

Brad Triebwasser <btriebw@chromium.org> wrote:

Revert "View-transitions should only be allowed when page is visible"

This reverts commit 763158dc9602048a522e165a8dcdabcc9da37db7.

Reason for revert: [Gardening] Test hide-before-reveal.html is consistently failing on CI bots.

Original change's description:

View-transitions should only be allowed when page is visible

  • Skip the transition if document becomes hidden
  • Disallow oubound cross-document view transitions when document is
    hidden
  • Skip inbound cross-document view transition if document becomes
    hidden
  • When calling startViewTransition() in a hidden document, start is
    as skipped.

Based on following CSS resolution:
https://github.com/w3c/csswg-drafts/issues/9543#issuecomment-1939242246

Bug: 329302331
Change-Id: Ieef3238240b35c5d7f7f819793f65f71d7d75037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374309
Reviewed-by: David Bokan \<bokan@chromium.org>
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1273445}

Bug: 329302331
Change-Id: Idd4ae8f47af123401e6c8d2673e26d23e296b9b1

Reviewed-on: https://chromium-review.googlesource.com/5375475
WPT-Export-Revision: a320b25e006ccde037480ef5b6dafa9b1d50bf58

PR 45143 applied with additional changes from upstream: de64b61df17bec0ed1e2777ab717bec6f8959a25
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/265159dfc181 [wpt PR 45143] - Revert "View-transitions should only be allowed when page is visible", a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/265159dfc181

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.