1885812 - comm/mailnews/local/src/nsParseMailbox.cpp, a semaphore is not released in an error return path

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[ISHIKAWA, Chiaki (back from day job exhibition event.)]

A semaphore is not released in an error return path in
comm/mailnews/local/src/nsParseMailbox.cpp.

https://searchfox.org/comm-central/source/mailnews/local/src/nsParseMailbox.cpp#2272

A return statement before that is preceded by a release statement.
https://searchfox.org/comm-central/source/mailnews/local/src/nsParseMailbox.cpp#2266

The remaining code returns with a return statement at the end, and that return is preceded by a release statement.
https://searchfox.org/comm-central/source/mailnews/local/src/nsParseMailbox.cpp#2300

A simple oversight, I think.
A patch will follow.

Comment 1

[ISHIKAWA, Chiaki (back from day job exhibition event.)]

Attachment: Bug 1885812, release semaphore in an early error return path, r=BenC

Comment 2

[Ben Campbell]

Simple enough that I'm just going to land this now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c318cb160c7
Release semaphore in early error return path. r=benc

Comment 4

[ISHIKAWA, Chiaki (back from day job exhibition event.)]

(In reply to Ben Campbell from comment #2)

Simple enough that I'm just going to land this now.

Thank you, Ben.