1885907 - Speedup webidl generation by reducing the amount of string operations

Status: RESOLVED WONTFIX

(Core :: DOM: Bindings (WebIDL), task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1885907 - No longer try to maintain good indentation of webidl generated file r=ahochheiden

This simplifies the code, and it's always possible to call clang-format
afterward if we want to work on generated file.

Depends on D204671

Comment 2

[Andrew McCreight [:mccr8]]

How much of an improvement is this?

Are you planning on writing a patch to run clang-format on the generated code? I don't even spend much time on DOM bindings, but I still frequently look at the generated code on SearchFox and linked from crash reports, so manually running clang-format locally won't solve the issue.

Comment 3

[Peter Van der Beken [:peterv]]

Yeah, I agree with mccr8. The current formatting sure isn't ideal, and it's hard to maintain, but simply ripping it out without replacing it with something better is a big step backwards.

Comment 4

[[:sergesanspaille]]

I ran some extra benchmark: running clang-format on the generated files adds a non negligible overhead, even when parallelized (by the order of the second).
I understand the requirement of being able to generate readable files, turns out this wasn't the right approach, closing as WONTFIX.