1886022 - Refactor canvas shutdown to account for process crashes

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1886022 - Refactor canvas shutdown to account for process crashes.

We previously refactor canvas shutdown to account for the fact that they
needed to be shutdown in conjunction with the DOM worker reference
kept alive by the CanvasManagerChild. Unfortunately if the compositor
process crashes, or otherwise the CanvasManagerChild actor is torn down,
we also prematurely shutdown the canvas when it would previously
fallback to Skia in the content process.

This patch abstracts out canvas shutdown into the CanvasShutdownManager
which has the owning reference to the ThreadSafeWorkerRef. It corrects a
similar bug on the main thread as well for HTMLCanvasElement.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e250e45603a
Refactor canvas shutdown to account for process crashes. r=gfx-reviewers,lsalzman

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing build bustages on CanvasShutdownManager.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&noTelemetry=1&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0e250e45603afb7b1039fab4ceecbd3cf6a7172d&selectedTaskRun=CDMAd1JUQ0epojNtmbZoqQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=451234797&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4872ae54a708638bc5394c4dad81b5ee46da6bfd

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Missing header.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b4c193400a2
Refactor canvas shutdown to account for process crashes. r=gfx-reviewers,lsalzman

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5b4c193400a2

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aosmond, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9391867 [details]
Bug 1886022 - Refactor canvas shutdown to account for process crashes.

Beta/Release Uplift Approval Request

• User impact if declined: OffscreenCanvas and HTMLCanvasElement may break when the GPU process crashes or runs into IPDL errors
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It moves us back to the original behaviour used by HTMLCanvasElement expanded to DOM workers. It will be a lot more consistent.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9391867 [details]
Bug 1886022 - Refactor canvas shutdown to account for process crashes.

Approved for 125.0b4.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e93a9b124e8