Open Bug 1886233 Opened 11 months ago Updated 10 months ago

New wpt failures in /css/css-backgrounds/animations/box-shadow-interpolation.html

Categories

(Core :: CSS Transitions and Animations, defect)

Product:
Core
Component:
CSS Transitions and Animations
Type:
defect

Tracking

()

People

(Reporter: wpt-sync, Assigned: tlouw)

References

Details

(Whiteboard: [wpt])

Syncing wpt PR 45127 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

  • /css/css-backgrounds/animations/box-shadow-interpolation.html [wpt.fyi]
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px rgb(0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px rgb(255 255 255)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Transitions with transition: all: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • CSS Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (-0.3) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0) should be [10px 10px 10px 10px oklab(0 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.3) should be [10px 10px 10px 10px oklab(0.3 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (0.6) should be [10px 10px 10px 10px oklab(0.6 0 0)]: FAIL
    • Web Animations: property <box-shadow> from [10px 10px 10px 10px color(srgb 0 0 0)] to [10px 10px 10px 10px color(srgb 1 1 1)] at (1) should be [10px 10px 10px 10px oklab(1 0 0)]: FAIL

CI Results

Missing results from treeherder
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1885548 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Tiaan, maybe you could take a look, when you've got cycles, if this looks straightforward?

It's not clear in comment 0, but if you click through to the test, you can see that all of the failures are something like
"expected: [value expressed in oklab], got: [value expressed in srgb]"

e.g.

assert_equals: expected "oklab ( 0 0 0 ) 10px 10px 10px 10px " but got "color ( srgb - 0.3 - 0.3 - 0.3 ) 10px 10px 10px 10px "
assert_equals: expected "oklab ( 0 0 0 ) 10px 10px 10px 10px " but got "color ( srgb 0 0 0 ) 10px 10px 10px 10px "
assert_equals: expected "oklab ( 0.3 0 0 ) 10px 10px 10px 10px " but got "color ( srgb 0.3 0.3 0.3 ) 10px 10px 10px 10px "

There are a zillion of them, but they all look like basically the same thing, I think (doing interpolation in the wrong space, probably?)

Flags: needinfo?(tlouw)
Severity: -- → S3
Component: Layout: Images, Video, and HTML Frames → CSS Transitions and Animations

There is a simple rule to either output an rgb(...) color or an oklab(...) color after mixing.

https://searchfox.org/mozilla-central/rev/6121b33709dd80979a6806ff59096a561e348ae8/servo/components/style/color/mix.rs#86

If both sides are rgb, hsl or hwb, then the result is in rgb, otherwise the result should be in oklab.

Most of them just look like its selecting the wrong one, but that usually depends on where the colors are coming from.

I will take a look.

Assignee: nobody → tlouw
Flags: needinfo?(tlouw)
You need to log in before you can comment on or make changes to this bug.