1886335 - [WebGPU] Demo at https://codepen.io/dawken/pen/XWPNJBx doesnt draw anything in Nightly

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P3)

Description

[Mayank Bansal]

Go to https://codepen.io/dawken/pen/XWPNJBx

AR: Nothing is drawn on the screen
ER: Chrome can render this. So should we

tured WebGPU error: Shader module creation failed: Shader validation error
09:03:38.877
Encountered one or more errors while creating shader module
09:03:38.877
WebGPU compilation info for shader module (1 error(s), 0 warning(s), 0 info)
09:03:38.877

Shader validation error:
┌─ :55:7
│
55 │ ╭ fn reportCollision(nodeIndex: u32, queryIndex: u32) {
56 │ │ if (nodeIndex == queryIndex) {
57 │ │ return;
58 │ │ }
59 │ │
60 │ │ let listIndex = atomicAdd(&collisions.count, 1);
│ │ ^ naga::Expression [6]
· │
65 │ │
66 │ │ collisions.collisions[listIndex] = collision;
│ ╰─────────────────────────────────────────────────────^ naga::Function [4]

09:03:38.877 Uncaptured WebGPU error: Error matching shader requirements against the pipeline, caused by: Shader module is invalid
09:03:38.877
Encountered one or more errors while creating shader module
09:03:38.877
WebGPU compilation info for shader module (1 error(s), 0 warning(s), 0 info)
09:03:38.877

Shader validation error:
┌─ :41:29
│
41 │ let nodeIndex = u32(1 << (params.height - buildPhase - 1u)) + global_id.x;
│ ^ naga::Expression [2]

09:03:38.890 Uncaptured WebGPU error: In a set_pipeline command, caused by: Compute pipeline Id(2,1,d3d12) is invalid

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: traverseModule.wgsl

.

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: buildModule.wgsl

.

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

The offending shaders and their full diagnostics from naga-cli:

• traverseModule.wgsl:

   [2024-03-20T14:18:13Z ERROR naga::valid::function] Atomic operand type Scalar(Scalar { kind: Sint, width: 4 })
   error:
      ┌─ in.wgsl:54:1
      │
   54 │ ╭ fn reportCollision(nodeIndex: u32, queryIndex: u32) {
   55 │ │   if (nodeIndex == queryIndex) {
   56 │ │     return;
   57 │ │   }
   58 │ │
   59 │ │   let listIndex = atomicAdd(&collisions.count, 1);
      │ │                                                ^ naga::Expression [6]
      · │
   64 │ │
   65 │ │   collisions.collisions[listIndex] = collision;
      │ ╰───────────────────────────────────────────────^ naga::Function [4]
  
   Function [4] 'reportCollision' is invalid:
   		Atomic operation is invalid
   		Operand [6] has invalid type.
  

  This is bug 1829879.

• buildModule.wgsl

   error:
      ┌─ in.wgsl:40:23
      │
   40 │   let nodeIndex = u32(1 << (params.height - buildPhase - 1u)) + global_id.x;
      │                       ^ naga::Expression [2]
  
   Entry point main at Compute is invalid:
   		Expression [2] is invalid
   		Abstract types may only appear in constant expressions
  

  This is also bug 1829879.

Comment 5

[Andy Leiserson [:aleiserson]]

atomicAdd

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

This now WFM!