Closed Bug 1886346 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 45213 - ComputePressure: reformat sampleRate to sampleInterval

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45213 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45213
Details from upstream follow.

Arnaud Mandy <arnaud.mandy@intel.com> wrote:

ComputePressure: reformat sampleRate to sampleInterval

Following specifications change [1], sampleRate in hertz is changed to
sampleInterval in millisecond.

https://github.com/w3c/compute-pressure/pull/254

Bug: 330376756
Change-Id: Ibe909d537e462cd251d28c7d4d4702341dc33c0c
Reviewed-on: https://chromium-review.googlesource.com/5381598
WPT-Export-Revision: 519450698e81dd0cf1896da75b622cde4041c6fd

PR 45213 applied with additional changes from upstream: 031d05d8562bc010928123c9e9417a2b882ac2da

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 39 tests and 32 subtests

Status Summary

Firefox

OK : 39
PASS : 4
FAIL : 165

Chrome

OK : 38
PASS : 162
FAIL : 6
TIMEOUT: 2

Safari

OK : 39
PASS : 4
FAIL : 165

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /compute-pressure/compute_pressure_basic.https.any.worker.html [wpt.fyi]
    • Return NotSupportedError when calling observer(): FAIL (Chrome: PASS, Safari: FAIL)
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves works: FAIL (Chrome: PASS, Safari: FAIL)
    • Calling observe() multiple times works: FAIL (Chrome: PASS, Safari: FAIL)
    • Starting a new observer after an observer has started works: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_basic.https.any.sharedworker.html [wpt.fyi]
    • Return NotSupportedError when calling observer(): FAIL (Chrome: PASS, Safari: FAIL)
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves works: FAIL (Chrome: PASS, Safari: FAIL)
    • Calling observe() multiple times works: FAIL (Chrome: PASS, Safari: FAIL)
    • Starting a new observer after an observer has started works: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_basic.https.any.html [wpt.fyi]
    • Return NotSupportedError when calling observer(): FAIL (Chrome: PASS, Safari: FAIL)
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves works: FAIL (Chrome: PASS, Safari: FAIL)
    • Calling observe() multiple times works: FAIL (Chrome: PASS, Safari: FAIL)
    • Starting a new observer after an observer has started works: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_detached_iframe.https.html [wpt.fyi]
    • PressureObserver.observe() on detached frame rejects: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver.disconnect() on detached frame returns: FAIL (Chrome: PASS, Safari: FAIL)
    • Detaching frame while PressureObserver.observe() settles: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver on detached frame returns with no callback: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect.https.any.html [wpt.fyi]
    • Call disconnect() directly should not crash: FAIL (Chrome: PASS, Safari: FAIL)
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect.https.any.sharedworker.html [wpt.fyi]
    • Call disconnect() directly should not crash: FAIL (Chrome: PASS, Safari: FAIL)
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect.https.any.worker.html [wpt.fyi]
    • Call disconnect() directly should not crash: FAIL (Chrome: PASS, Safari: FAIL)
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_idempotent.https.any.sharedworker.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_idempotent.https.any.worker.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_idempotent.https.any.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_immediately.https.any.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_immediately.https.any.sharedworker.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_disconnect_immediately.https.any.worker.html [wpt.fyi]
    • Stopped PressureObserver do not receive changes: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing observer before observe() resolves does not affect other observers: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_duplicate_updates.https.any.html [wpt.fyi]
    • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_duplicate_updates.https.any.sharedworker.html [wpt.fyi]
    • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_duplicate_updates.https.any.worker.html [wpt.fyi]
    • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_multiple.https.any.html [wpt.fyi]
    • Three PressureObserver instances receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_multiple.https.any.sharedworker.html [wpt.fyi]
    • Three PressureObserver instances receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_multiple.https.any.worker.html [wpt.fyi]
    • Three PressureObserver instances receive changes: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_observe_idempotent.https.any.worker.html [wpt.fyi]
    • PressureObserver.observe() is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_observe_idempotent.https.any.sharedworker.html [wpt.fyi]
    • PressureObserver.observe() is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_observe_idempotent.https.any.html [wpt.fyi]
    • PressureObserver.observe() is idempotent: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_options.https.any.html [wpt.fyi]
    • PressureObserver constructor doesnt throw error for sampleInterval value 0: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver constructor requires a positive sampleInterval: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor requires a sampleInterval in unsigned long range: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor succeeds on empty sampleInterval: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_options.https.any.worker.html [wpt.fyi]
    • PressureObserver constructor doesnt throw error for sampleInterval value 0: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver constructor requires a positive sampleInterval: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor requires a sampleInterval in unsigned long range: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor succeeds on empty sampleInterval: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_options.https.any.sharedworker.html [wpt.fyi]
    • PressureObserver constructor doesnt throw error for sampleInterval value 0: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver constructor requires a positive sampleInterval: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor requires a sampleInterval in unsigned long range: FAIL (Chrome: FAIL, Safari: FAIL)
    • PressureObserver constructor succeeds on empty sampleInterval: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_rate_obfuscation_mitigation_not_triggered.https.window.html [wpt.fyi]
    • No rate obfuscation mitigation should happen, when number of changes is below minimum changes before penalty: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_rate_obfuscation_mitigation_triggered.https.window.html [wpt.fyi]
    • Rate obfuscation mitigation should have been triggered, when changes is higher than minimum changes before penalty: FAIL (Chrome: TIMEOUT, Safari: FAIL)
  • /compute-pressure/compute_pressure_take_records.https.any.worker.html [wpt.fyi]
    • Calling takeRecords() before observe(): FAIL (Chrome: PASS, Safari: FAIL)
    • takeRecords() returns empty record after callback invoke: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_take_records.https.any.sharedworker.html [wpt.fyi]
    • Calling takeRecords() before observe(): FAIL (Chrome: PASS, Safari: FAIL)
    • takeRecords() returns empty record after callback invoke: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_take_records.https.any.html [wpt.fyi]
    • Calling takeRecords() before observe(): FAIL (Chrome: PASS, Safari: FAIL)
    • takeRecords() returns empty record after callback invoke: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_timestamp.https.any.worker.html [wpt.fyi]
    • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: FAIL (Chrome: PASS, Safari: FAIL)
    • disconnect() should update [[LastRecordMap]]: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_timestamp.https.any.html [wpt.fyi]
    • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: FAIL (Chrome: PASS, Safari: FAIL)
    • disconnect() should update [[LastRecordMap]]: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_timestamp.https.any.sharedworker.html [wpt.fyi]
    • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: FAIL (Chrome: PASS, Safari: FAIL)
    • disconnect() should update [[LastRecordMap]]: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_update_toJSON.https.any.html [wpt.fyi]
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_update_toJSON.https.any.sharedworker.html [wpt.fyi]
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/compute_pressure_update_toJSON.https.any.worker.html [wpt.fyi]
    • Basic functionality test: FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/idlharness.https.any.sharedworker.html [wpt.fyi]
    • idl_test setup: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation observe(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation unobserve(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation disconnect(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation takeRecords(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: attribute supportedSources: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver must be primary interface of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • Stringification of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "observe(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling observe(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "unobserve(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling unobserve(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "disconnect()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "takeRecords()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "supportedSources" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute source: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute state: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute time: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: operation toJSON(): FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/idlharness.https.any.html [wpt.fyi]
    • idl_test setup: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation observe(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation unobserve(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation disconnect(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation takeRecords(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: attribute supportedSources: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver must be primary interface of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • Stringification of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "observe(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling observe(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "unobserve(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling unobserve(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "disconnect()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "takeRecords()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "supportedSources" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute source: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute state: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute time: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: operation toJSON(): FAIL (Chrome: PASS, Safari: FAIL)
  • /compute-pressure/idlharness.https.any.worker.html [wpt.fyi]
    • idl_test setup: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation observe(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation unobserve(PressureSource): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation disconnect(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: operation takeRecords(): FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: attribute supportedSources: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver must be primary interface of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • Stringification of observer: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "observe(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling observe(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "unobserve(PressureSource)" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: calling unobserve(PressureSource) on observer with too few arguments must throw TypeError: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "disconnect()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "takeRecords()" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureObserver interface: observer must inherit property "supportedSources" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute source: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute state: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: attribute time: FAIL (Chrome: PASS, Safari: FAIL)
    • PressureRecord interface: operation toJSON(): FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f693ea555086 [wpt PR 45213] - ComputePressure: Turn sampleRate into sampleInterval, a=testonly https://hg.mozilla.org/integration/autoland/rev/e0be995840a4 [wpt PR 45213] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f693ea555086
https://hg.mozilla.org/mozilla-central/rev/e0be995840a4

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.