1886419 - Fix "continue to here" in code mirror 6

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Hubert Boma Manilla (:bomsy) PTO until Sept 1st]

STR

• Go to https://todomvc.com/
• Open the debugger (make sure the devtools.debugger.features.codemirror-next is true)
• Go to https://todomvc.com/site-assets/main.js
• Set a breakpoint on line 16
• Hover mouse over the web page till debugger pauses on line 16
• CMD + Click on line 18

Expected

Debugger should resume and pause on line 18.
The debug line should be visible and the breakpoint marker in the gutter should be hidden.
There should be a breakpoint added to the breakpoints list.

Actual

The gutter breakpoint flashes and disappears.
No debug-line
No breakpoint is added to the breakpoint list.

Comment 1

[Hubert Boma Manilla (:bomsy) PTO until Sept 1st]

Note: On the "Continue to here", a breakpoint should not be added to the list.

Also testing this, i now see the debug line, so what is left to fix is the flashes of the gutter breakpoint.

Comment 2

[Hubert Boma Manilla (:bomsy) PTO until Sept 1st]

Attachment: Bug 1886419 - [devtools] Don't try to render hidden breakpoints r=#devtools-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25b47c1560bc
[devtools] Don't try to render hidden breakpoints r=devtools-reviewers,ochameau

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/25b47c1560bc

Comment 5

[Ina Popescu, Desktop QA]

I've replicated the issues mentioned in Comment 0 and Comment 1 using Nightly 126.0a1 and Nightly 128.0a1 on Windows 10 x64, following the STR provided.
I've observed that the issue noted in Comment 1 is still reproducible in the latest Nightly 130.0a1 and Firefox 129.0b8 on both Windows 10 x64 and Ubuntu 22.04.
@Hubert Boma Manilla, could you please have a look? Thank you.

Comment 6

[Hubert Boma Manilla (:bomsy) PTO until Sept 1st]

(In reply to Ina Popescu, Desktop QA from comment #5)

I've observed that the issue noted in Comment 1 is still reproducible in the latest Nightly 130.0a1 and Firefox 129.0b8 on both Windows 10 x64 and Ubuntu 22.04.
@Hubert Boma Manilla, could you please have a look? Thank you.

Hi Ina,
Do you have a screen cast of what you see? I've tested on 130.0a1 and i do not seem to see the issues mentioned in Comment 1

Thanks

Comment 7

[Ina Popescu, Desktop QA]

Attachment: Ctrl + Click on line 18.mp4

Please see that attached video.

Comment 8

[Hubert Boma Manilla (:bomsy) PTO until Sept 1st]

(In reply to Ina Popescu, Desktop QA from comment #7)

Created attachment 9416520 [details]
Ctrl + Click on line 18.mp4

Please see that attached video.

Thanks for the video.
Ah ok, it looks like you still have the codemirror 5 version. Did you set the devtools.debugger.features.codemirror-next pref to true ?

Comment 9

[Ina Popescu, Desktop QA]

Attachment: Ctrl + click on line 18__Beta 129.0b9.mp4

I apologize for any confusion. It seems I missed this step while recording the video, even though the pref devtools.debugger.features.codemirror-next was flipped in my previous tests. However, it appears the browser needs to be restarted after flipping this pref, which may have influenced my test results.
I have retested under these conditions in both Nightly 130.0a1 and Firefox 129.0b9, and attached the videos for both tests. Thanks

Comment 10

[Ina Popescu, Desktop QA]

Attachment: Ctrl + click on line 18_Nightly 130.0a1.mp4