Closed Bug 1886586 Opened 6 months ago Closed 6 months ago

Enabling caret browsing mode with F7 only take effect after reloading the pdf

Categories

(Firefox :: PDF Viewer, defect, P1)

Product:
Firefox
Component:
PDF Viewer
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox124 --- wontfix
firefox125 --- verified
firefox126 --- verified

People

(Reporter: calixte, Assigned: calixte)

References

Details

Attachments

(4 files)

[mozilla/pdf.js] [Editor] Update caret browsing mode when the pref is changed in Firefox (bug 1886586) (#17816)
44 bytes, text/x-github-pull-request
Details | Review
Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed r=#pdfjs-reviewers
48 bytes, text/x-phabricator-request
Details | Review
[mozilla/pdf.js] Allow listening for preference changes in the Firefox PDF viewer (bug 1886586) (#17818)
44 bytes, text/x-github-pull-request
Details | Review
Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed r=#pdfjs-reviewers
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-beta+
Details | Review

STR:

  • Make sure caret browsing mode is disabled
  • Open a pdf
  • Enable caret browsing mode
  • Click somewhere and move the cursor with with up/down keys

Expected results:
The caret should move up/down.

Actual results:
Pressing arrow keys changes the current page.

Attachment #9392539 - Attachment description: WIP: Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed → WIP: Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed r=#pdfjs-reviewers
Attachment #9392539 - Attachment description: WIP: Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed r=#pdfjs-reviewers → Bug 1886586 - Update the caret browsing mode in the pdf viewer when the pref is changed r=#pdfjs-reviewers
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Pushed by cdenizet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36531ba97e00 Update the caret browsing mode in the pdf viewer when the pref is changed r=pdfjs-reviewers,marco

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(cdenizet)
status-firefox125: affected → wontfix
Flags: needinfo?(cdenizet)
Attachment #9394585 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: User will have to reload the viewer if they change the caret browsing mode
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See comment#0
  • Risk associated with taking this patch: Low
  • Explanation of risk level: Small and self contained change.
  • String changes made/needed: No
  • Is Android affected?: no
Flags: qe-verify+
Attachment #9394585 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: in-testsuite+
QA Whiteboard: [qa-triaged]

Verified as fixed in our latest Nightly and our latest Beta 125.0b8.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
status-firefox125: fixed → verified
status-firefox126: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: