1886595 - 0.42% installer size (OSX) regression on Wed March 13 2024

Status: RESOLVED WONTFIX

(Firefox :: Installer, defect)

Description

[Alex Finder]

Perfherder has detected a build_metrics performance regression from push 92a289c24e7c7e5e81099c3b556d93f32d3efa7a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.42%	installer size	osx-cross		92,695,612.00 -> 93,087,441.42

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

You can run these tests on try with ./mach try perf --alert 41773

For more information on performance sheriffing please see our FAQ.

Comment 1

[Nipun Shukla]

Hi, thanks for bringing this to my attention. This push introduces a new executable to the Firefox app bundle. This new executable is necessary for a new feature being implemented that uses external native messaging. If I’m reading the change correctly, the (what looks like to me) ~400 KB increase in size makes sense, unless there’s evidence to the contrary.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1876344