1886730 - Crash in [@ java.lang.NullPointerException: at mozilla.appservices.remotesettings.RemoteSettings.getRecords(remote_settings.kt)]

Status: RESOLVED FIXED

(Application Services :: Remote Settings, defect)

Description

[Dianna Smith [:diannaS]]

Crash report: https://crash-stats.mozilla.org/report/index/33002e9c-8569-4c09-a8f6-16b6f0240321

Comment 1

[Lina Butler (ex-Mozilla)]

This exception looks like it's coming from the Android Components wrapper around the Rust Remote Settings client, not the Rust client itself.

I think it might be this line. e.message is a String?, but we don't check if it's null, so we crash trying to call null.toString().

Matt, Sarah, could that be possible?

Comment 2

[[:skhan]]

Attachment: Bug 1886730 - catch NLP during RemoteSetting getRecords() failure

Comment 3

[Lina Butler (ex-Mozilla)]

Nope, it's not e.message.toString(); Matt pointed out that Any?.toString() is safe:

Can be called with a null receiver, in which case it returns the string "null".

There's something else going on.

Comment 4

[Matt Tighe [:matt-tighe]]

I think we should accept Sarah's patch to swallow the exception and prevent the crash for now and either file a follow-up to continue investigating the root cause or leave this bug as unresolved until we can find it

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4d445d1657
catch NLP during RemoteSetting getRecords() failure r=android-reviewers,matt-tighe

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a72436b5d5bf
Fix klint failure a=lint-fix CLOSED TREE

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing detekt & klint failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/4ad3597787fed9885ed7cb37ad5c04348f688060

Push with failures

Failure log -> klint

Failure log -> detekt

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/9f6186fead44
catch NLP during RemoteSetting getRecords() failure

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9f6186fead44

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1886730 - catch NLP during RemoteSetting getRecords() failure (#6045)

Comment 11

[[:skhan]]

Comment on attachment 9392626 [details] [review]
[mozilla-mobile/firefox-android] Bug 1886730 - catch NLP during RemoteSetting getRecords() failure (#6045)

Beta/Release Uplift Approval Request

• User impact if declined: Will face a crash
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just catching an exception that would be fixing the other prominent bug
• String changes made/needed: No
• Is Android affected?: Yes

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1886730 - catch NLP during RemoteSetting getRecords() failure (#6046)

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9392628 [details] [review]
[mozilla-mobile/firefox-android] Bug 1886730 - catch NLP during RemoteSetting getRecords() failure (#6046)

Approved for Mobile 125.0b3

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9392626 [details] [review]
[mozilla-mobile/firefox-android] Bug 1886730 - catch NLP during RemoteSetting getRecords() failure (#6045)

Approved for Mobile 124.1.0