1886771 - Can't use accel + n or accel + t with VSCode in full screen mode

Status: NEW

(Web Compatibility :: Site Reports, enhancement, P3)

Description

[James Graham [:jgraham]]

1. Load https://vscode.dev/
2. Use [Hamburger menu] → View → Appearance → Fullscreen to get into fullscreen mode (or press F11).
3. Try to use accel+n to open a new document (where accel = cmd or ctrl depending on platform)

Instead of getting a new document you get a new Firefox window.

Comment 1

[Thomas Wisniewski [:twisniewski]]

gijs helped determine that this is related to the Keyboard Lock API (https://chromestatus.com/feature/5642959835889664, https://github.com/mozilla/standards-positions/issues/196).

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Thomas Wisniewski [:twisniewski] from comment #1)

gijs helped determine that this is related to the Keyboard Lock API (https://chromestatus.com/feature/5642959835889664, https://github.com/mozilla/standards-positions/issues/196).

Hi Thomas! Would you please elaborate more on if we really need both bug 1891067 and bug 1593883 for this issue? It looks to me bug 1593883 should suffice and there's a clear path forward. Thanks!

Comment 3

[:Gijs (he/him)]

(In reply to Hsin-Yi Tsai (she/her) [:hsinyi] from comment #2)

(In reply to Thomas Wisniewski [:twisniewski] from comment #1)

gijs helped determine that this is related to the Keyboard Lock API (https://chromestatus.com/feature/5642959835889664, https://github.com/mozilla/standards-positions/issues/196).

Hi Thomas! Would you please elaborate more on if we really need both bug 1891067 and bug 1593883 for this issue? It looks to me bug 1593883 should suffice and there's a clear path forward. Thanks!

AIUI the keyboard lock API specifies a way sites can indicate what shortcut keys they want to use and is broader than just accel-n/accel-t. So to me it makes sense to have both bugs.