1886773 - When using a git repository, `moz-phab submit HASH` excludes the specified HASH

Status: RESOLVED WONTFIX

(Conduit :: moz-phab, defect)

Description

[Julien Wajsberg [:julienw]]

moz-phab version (from moz-phab --version): 1.4.0
Python version (from python3 --version): 3.11.2
OS: Linux Debian Stable

Hi,

I noticed that moz-phab submit has a different behavior on git compared to hg, when specifying a revision as a parameter.

For example, imagine you want to submit just the last commit.
On hg:

$ moz-phab submit tip

But on git:

$ moz-phab submit HEAD
Failed to find any commits to submit

Indeed on git, it looks like this is exclusive. This works though:

$ moz-phab submit HEAD^

The same happens when using a range or a hash.

I'd be happy to fix it if you're open to a patch.

Comment 1

[Julien Wajsberg [:julienw]]

Should the condition be removed in https://github.com/mozilla-conduit/review/blob/f9fae7d5bf240d2a395359728e1a5738360eccb8/mozphab/git.py#L268-L272 ?

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1886773 - When using a git repository, `moz-phab submit HASH` should include the specified HASH r=zeid

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: Bug 1886773 - Slightly update the README so that the build instructions are copy-pastable r=zeid

Comment 4

[Julien Wajsberg [:julienw]]

Integration tests for git are broken, I need to understand how they work.

Comment 5

[Connor Sheehan [:sheehan]]

Julien, see my comment on https://phabricator.services.mozilla.com/D205331.

As an aside, I noticed you're using moz-phab 1.4.0. You should manually update to the latest version, 1.5.1, since that version fixes the auto-update mechanism. I sent a dev-platform announcement about this a while ago. :)

Comment 6

[Julien Wajsberg [:julienw]]

I think this ship has sailed now, we could revisit after the git migration but now doesn't seem like a good moment to change this. Also I don't find myself enough time to come back at it :-)
Closing!