1886953 - Introduce deCOMtaminated IDNA functions and benchmark them

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Henri Sivonen (:hsivonen)]

To prepare for swapping in a different back end, add deCOMtaminated IDNA/UTS46 conversion functions (currently delegating to the XPCOM methods) and benchmark them.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1886953 - Introduce deCOMtaminated IDNA functions and benchmark them

The plan is to replace the implementations of these functions with an
ICU4X/Rust back end and then make the XPCOM versions call into these.

Migrating existing C++ callers is out of scope for this changeset.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05e59b9d620c
Introduce deCOMtaminated IDNA functions and benchmark them r=necko-reviewers,valentin

Comment 3

[tszentpeteri]

Backed out for causing build bustages on nsStandardURL.h

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/nsStandardURL.h:201:50: error: no viable conversion from returned value of type 'StaticRefPtr<nsIIDNService>' to function return type 'nsIIDNService *'

Comment 4

[Henri Sivonen (:hsivonen)]

Try run of a trivial build fix: https://treeherder.mozilla.org/jobs?repo=try&revision=195b034807d1b58de1fb095dcfb7790134bd3eaa

Comment 5

[Henri Sivonen (:hsivonen)]

Try run with another trivial build fix for another non-unified failure:
https://treeherder.mozilla.org/jobs?repo=try&revision=21882d0ba2fb5b5cb5319795e656873fcd977e64

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/870a2b89741b
Introduce deCOMtaminated IDNA functions and benchmark them r=necko-reviewers,valentin

Comment 7

[Cristian Tuns]

Backed out for causing gtest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: SUMMARY: AddressSanitizer: global-buffer-overflow /builds/worker/workspace/obj-build/dist/include/nsStringIterator.h:49:36 in operator*

Comment 8

[Henri Sivonen (:hsivonen)]

(In reply to Cristian Tuns from comment #7)

• Failure line: SUMMARY: AddressSanitizer: global-buffer-overflow /builds/worker/workspace/obj-build/dist/include/nsStringIterator.h:49:36 in operator*

Filed as bug 1887815. Marking this bug security-sensitive for now.

Comment 9

[Andrew McCreight [:mccr8]]

I'll mark this sec-other because the actual sec problem has bug 1887815 filed for it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cf3c978bbf4
Introduce deCOMtaminated IDNA functions and benchmark them r=necko-reviewers,valentin

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8cf3c978bbf4