1886959 - Undo functionality stops working after Deleting a Highlight in a PDF file

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Rares Doghi, Desktop QA]

Found in

• 126.0a1 (2024-03-21)

Affected versions

• 126.0a1 (2024-03-21)
• Beta 125.0b3

Affected platforms

• ALL

Preconditions:
pdfjs.enableHighlightEditor - true
pdfjs.enableHighlightFloatingButton - true

Steps to reproduce

1. Have a PDF opened in Firefox.
2. Highlight any text.
3. Delete the Highlight.
4. Hit Ctrl + Z on the keyboard or Right Click > Undo

Expected result

• The Highlight should be displayed again.

Actual result

• Undo stops working after we delete a Highlight.

Regression range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0d1a1dbfd5c36a2527b566ff831a989ca5ae5f5&tochange=5804e635dd1e6f9bac06c845381fc1e3c434e72e

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:calixte, since you are the author of the regressor, bug 1885306, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Fix undoing an editor deletion (bug 1886959) (#17823)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 4

[Rares Doghi, Desktop QA]

This is Verified as fixed in our latest Nightly build 126.0a1 (2024-03-28).

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 125.0b8.