1887019 - Set `id-ID` on accept-language, not `in-ID`

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Makoto Kato [:m_kato]]

When setting Indonesia as Locale, we should set id-ID on accept-language, not in-ID. This is regression by 1847701.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1887019 - Don't use old language code on accept-language. r=#geckoview-reviewers

Android may return old language code. So we should replace with newer
language code like desktop and etc.

Also, I would like to move it to org.mozilla.gecko.util to write unit test.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847701

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d22ca4e6803
Don't use old language code on accept-language. r=geckoview-reviewers,platform-i18n-reviewers,ohall,dminor

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0d22ca4e6803

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval ASAP so we can get this fixed for the Fx125 RC build on Monday.

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 9392762 [details]
Bug 1887019 - Don't use old language code on accept-language. r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: When UI language is Indonesian, accept-language in HTTP request has in-ID. We should be "id-ID" for this language.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Convert legacy languages to new langues only.
• String changes made/needed: No
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9392762 [details]
Bug 1887019 - Don't use old language code on accept-language. r=#geckoview-reviewers

Approved for 125.0rc1.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/612c1362f538