1887083 - Fix function type of 'substring' builtin

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Ryan Hunt [:rhunt]]

We currently have it return a nullable externref, when it should be a non-nullable externref.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1887083 - wasm: Mark js-string builtin function results as non-nullable. r?yury

The proposal has all the builtins return non-nullable externref, so update the
implementation. The exception is concat, but I think this will change so I
filed [1].

[1] https://github.com/WebAssembly/js-string-builtins/issues/24

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rhunt, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb5f7fdde18
wasm: Mark js-string builtin function results as non-nullable. r=yury

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/aeb5f7fdde18