1887117 - Failing WPT css/css-cascade/all-prop-revert-layer.html

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

See https://wpt.fyi/results/css/css-cascade/all-prop-revert-layer.html

Safari and Chrome pass.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Actually, the test is marked as "missing" on wpt.fyi, but we seem to pass all if when I run it on wpt.live: http://wpt.live/css/css-cascade/all-prop-revert-layer.html

The same is true for http://wpt.live/css/css-cascade/all-prop-initial-xml.html

@jgraham, why might these tests be "missing" on wpt.fyi?

Comment 2

[James Graham [:jgraham]]

https://github.com/web-platform-tests/wpt/blob/9820252a70/css/css-cascade/all-prop-revert-layer.html#L448-L451 seems to skip the test if the property is unsupported. That's bad :)

Maybe it would make sense to change it to call assert_implements_optional at the start of the test, which would give PRECONDITION FAILED as the status in that case, but just removing those checks and asserting in the test that the value isn't the empty string seems fine to me. Failing tests for things you don't support seems fair, and if we were ever doing this in a context where it makes sense to count scores (e.g. Interop) we'd have to refactor the test to not include a random mix of CSS properties anyway.

Comment 3

[Daniel Holbert [:dholbert]]

[Mass-triaging the batch of recently filed "Failing WPT" bugs as S3. If you want to filter out this bugmail, you can search for the string "volatile knot".]