1887118 - Network event cookies are missing all properties except name and value

Status: NEW

(Remote Protocol :: WebDriver BiDi, defect, P3)

Description

[Julian Descottes [:jdescottes]]

The current network event cookies only contain name and value on Firefox.
They should be regular network.Cookie objects:

network.Cookie = {
    name: text,
    value: network.BytesValue,
    domain: text,
    path: text,
    size: js-uint,
    httpOnly: bool,
    secure: bool,
    sameSite: network.SameSite,
    ? expiry: js-uint,
    Extensible,
};

https://w3c.github.io/webdriver-bidi/#serialize-cookie

I think we discussed this limitation when we implemented the events, but I don't think we filed bugs or wrote tests about it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

Hi Valentin,

Right now we parse the headers from the channel (using visitRequestHeaders) and when we spot the cookie header, we simply parse it to extract name and values of the cookies.

Do you know if there is any API which we could use to easily get full details about the cookies for a given request (eg samesite, issecure, etc...). Otherwise we would use various APIs from Services.cookies but I wanted to check first with you if there was a better approach.

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

Currently cookies are added to the request this way:
HttpBaseChannel::AddCookiesToRequest -> GetCookieStringFromHttp -> GetCookiesForURI.

I'm thinking you could use getCookiesFromHost to get all the cookies - they might need to be sorted through to make sure we don't send the ones we don't have to, like GetCookiesForURI does.

Alternatively, you could create a XPIDL binding for ParseAttributes, and use that to parse the cookie header set on the request. I think that might be easier.