1887118 - Network event cookies are missing all properties except name and value

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

The current network event cookies only contain name and value on Firefox.
They should be regular network.Cookie objects:

network.Cookie = {
    name: text,
    value: network.BytesValue,
    domain: text,
    path: text,
    size: js-uint,
    httpOnly: bool,
    secure: bool,
    sameSite: network.SameSite,
    ? expiry: js-uint,
    Extensible,
};

https://w3c.github.io/webdriver-bidi/#serialize-cookie

I think we discussed this limitation when we implemented the events, but I don't think we filed bugs or wrote tests about it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Julian Descottes [:jdescottes]]

Hi Valentin,

Right now we parse the headers from the channel (using visitRequestHeaders) and when we spot the cookie header, we simply parse it to extract name and values of the cookies.

Do you know if there is any API which we could use to easily get full details about the cookies for a given request (eg samesite, issecure, etc...). Otherwise we would use various APIs from Services.cookies but I wanted to check first with you if there was a better approach.

Comment 3

[Valentin Gosu [:valentin]]

Currently cookies are added to the request this way:
HttpBaseChannel::AddCookiesToRequest -> GetCookieStringFromHttp -> GetCookiesForURI.

I'm thinking you could use getCookiesFromHost to get all the cookies - they might need to be sorted through to make sure we don't send the ones we don't have to, like GetCookiesForURI does.

Alternatively, you could create a XPIDL binding for ParseAttributes, and use that to parse the cookie header set on the request. I think that might be easier.

Comment 4

[Jim Evans]

This issue prevents a client library that relies on strict compliance with the WebDriver BiDi specification from receiving and processing network events. WebDriverBiDi.NET is one such library, and one of its consumers is Puppeteer Sharp.

Comment 5

[Julian Descottes [:jdescottes]]

I have an implementation in progress, but I think we have a conflict between the spec and our current wdspec tests on this topic. https://github.com/w3c/webdriver-bidi/issues/1110

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1887118 - [bidi] Serialize all request cookie properties in network events

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1887118 - [wdspec] Update network tests to check all properties of cookies in event payload

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/32d6f056e962
https://hg.mozilla.org/integration/autoland/rev/15b6b9eee67c
[bidi] Serialize all request cookie properties in network events r=whimboo
https://github.com/mozilla-firefox/firefox/commit/cac21417c96a
https://hg.mozilla.org/integration/autoland/rev/71f0c2a21d10
[wdspec] Update network tests to check all properties of cookies in event payload r=whimboo

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/15b6b9eee67c
https://hg.mozilla.org/mozilla-central/rev/71f0c2a21d10

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59228 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Julian Descottes [:jdescottes]]

Some issues were spotted with the tests against Chrome, I pushed a PR upstream to fix this https://github.com/web-platform-tests/wpt/pull/59305