188712 - Apple's Browser Safari does not support server-push

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Pedro Melo]

User-Agent:       Mozilla/4.5 (compatible; OmniWeb/4.1.1-v424.6; Mac_PowerPC)
Build Identifier: 

The new browser from Apple, Safari, does not support server-push.

Editing the buglist.cgi, searching for multipart-mixed, and adding to the IF statement something like 

&& $ENV{HTTP_USER_AGENT} !~ /Safari/

solves the problem.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Dave Miller [:justdave]]

Ah, nifty.

my $serverpush =
  exists $ENV{'HTTP_USER_AGENT'}
    && $ENV{'HTTP_USER_AGENT'} =~ /Mozilla.[3-9]/
      && $ENV{'HTTP_USER_AGENT'} !~ /[Cc]ompatible/
        && $format->{'extension'} eq "html"
          && !defined($::FORM{'serverpush'})
            || $::FORM{'serverpush'};

so Safari doesn't say "compatible" I take it...

Comment 2

[Dave Miller [:justdave]]

Confirming....   buglist.cgi is definitely broken in Safari.

When I click the Search button, I get a file download of "buglist.cgi".
Examining the contents of said file shows it contains the entirety of the server
transmission, including the part headers.

Comment 3

[Bradley Baetz (:bbaetz)]

grr.

I'd suggest checking in the accept headers, but we don't list multipart push
there...

Comment 4

[Gervase Markham [:gerv]]

No, and we shouldn't - it's far too much of a niche feature.

Dave: any plans to support server push, or do we need to fix Bugzilla?

Gerv

Comment 5

[Pedro Melo]

FYI,The user agent safari is using rigth now (latest beta) is:Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/51 (like Gecko) Safari/51No compatible here...

Comment 6

[Pedro Melo]

Attachment: Do not use server-push with Apple Safari

Add's a check for Safari's user-agent to prevent server-push.

Comment 7

[Pedro Melo]

I provided the patch in case you want to fix this in bugzilla. I would prefer, of
course, that Apple fixes this in Safari.

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 111940 [details] [diff] [review]
Do not use server-push with Apple Safari

per Dave Hyatt in IRC, this probably will be fixed in Safari, but probably not
by 1.0.  He also says we should sniff for "WebKit" and not for "Safari" since
that way we'll catch anything else using Safari's libraries as well.

Comment 9

[Pedro Melo]

Attachment: new patch to sniff for WebKit

As suggested by David Hyatt, this patch sniff's for WebKit, instead of Safari.

Comment 10

[timeless]

Comment on attachment 112192 [details] [diff] [review]
new patch to sniff for WebKit

personally i think i'd check
$format->{'extension'} eq "html"
earlier (first?).

Comment 11

[Dave Miller [:justdave]]

-> patch author

Comment 12

[timeless]

checked in

Comment 13

[Dave Miller [:justdave]]

*** Bug 191022 has been marked as a duplicate of this bug. ***

Comment 14

[Dave Miller [:justdave]]

*** Bug 192326 has been marked as a duplicate of this bug. ***

Comment 15

[Dave Miller [:justdave]]

*** Bug 226807 has been marked as a duplicate of this bug. ***

Comment 16

[Dave Miller [:justdave]]

nominating for 2.16.5, as this is a usability issue and low-risk.

Comment 17

[Dave Miller [:justdave]]

checked in on 2.16 branch (applies without errors, and seems to work on landfill).

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.169.2.11; previous revision: 1.169.2.10
done

Comment 18

[Bob Williams]

I noticed the code for this in buglist.cgi in 3.1.4. Does this bug still apply to modern versions of Safari? We're going on version 4 now, and this bug dates to 1.0 from five years ago....

I set $serverpush to true then tried to load a bug list in Safari 3.1.1, and it came up just fine. However, I have few enough bugs in my install that every search is virtually instant, so I don't know if this bug would even be triggered.

Comment 19

[Gervase Markham [:gerv]]

It seems Safari has supported multipart/x-mixed-replace since 2.0.2 in 2005:
http://webkit.org/blog/32/webkit-fixes-in-safari-202-mac-os-x-1043/

Bug 441496 filed.

Gerv