1887435 - pointerup event isPrimary always true for touch

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[sandbox+mozilla]

Attachment: test.html

Firefox for Android

Steps to reproduce:

Open the attached page, which writes out the pointer event, pointerId, isPrimary to the page.

Touch the page with increasing and then decreasing number of fingers.

(The behavior is the same on Windows and Android.)

Actual results:

pointerdown 0 true
pointerdown 1 false
pointerdown 2 false
pointerup 2 true
pointerup 1 true
pointerup 0 true

Expected results:

pointerdown 0 true
pointerdown 1 false
pointerdown 2 false
pointerup 2 false
pointerup 1 false
pointerup 0 true

Comment 1

[Peter Van der Beken [:peterv]]

Edgar, any idea about this one?

Comment 2

[Edgar Chen [:edgar]]

I think it is a bug around https://searchfox.org/mozilla-central/rev/6b39381c0056c0dff0820fffebedf9980adc8883/dom/events/PointerEventHandler.cpp#684 where the touchend event might only contains one touch.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1887435 - Ensure the `isPrimary` property of `PointerEvent` is correctly set for touch input; r?smaug

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0591015c67d4
Ensure the `isPrimary` property of `PointerEvent` is correctly set for touch input; r=smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45672 for changes under testing/web-platform/tests

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/0591015c67d4

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot