1887649 - Show the Conditional/ Log breakpoint panel in Codemiror 6

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

This task migrates the components which inject widgets (e.g dom elements) into the editor content. These components are Conditional / Log points panel. Column Breakpoints, Inline Previews. Uses bookmarks and widgets. Fix any related tests which can be fixed.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1887649 - [devtools] Show the conditional/log breakpoint panel in codemirror 6 r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18051672452
[devtools] Show the conditional/log breakpoint panel in codemirror 6 r=devtools-reviewers,nchevobbe

Comment 3

[tszentpeteri]

Backed out for causing dt failures in browser_dbg-breakpoints-cond-ui-state.js.

• Backout link
• Push with failures
• Failure Log for dt8
• Failure Log for dt13
• Failure line:

[task 2024-04-30T06:23:31.016Z] 06:23:31     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond-ui-state.js | The textarea of conditional breakpoint panel is focused - 
[task 2024-04-30T06:23:31.017Z] 06:23:31     INFO - Click the conditional breakpoint in secondary pane
[task 2024-04-30T06:23:31.017Z] 06:23:31     INFO - Buffered messages finished
[task 2024-04-30T06:23:31.019Z] 06:23:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond-ui-state.js | The conditional breakpoint panel is closed - Got [object HTMLDivElement], expected null
[task 2024-04-30T06:23:31.020Z] 06:23:31     INFO - Stack trace:
[task 2024-04-30T06:23:31.020Z] 06:23:31     INFO - chrome://mochikit/content/browser-test.js:test_is:1620
[task 2024-04-30T06:23:31.021Z] 06:23:31     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond-ui-state.js:null:83
[task 2024-04-30T06:23:31.021Z] 06:23:31     INFO - chrome://mochikit/content/browser-test.js:handleTask:1139
[task 2024-04-30T06:23:31.021Z] 06:23:31     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1211
[task 2024-04-30T06:23:31.022Z] 06:23:31     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1353
[task 2024-04-30T06:23:31.022Z] 06:23:31     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1128
[task 2024-04-30T06:23:31.022Z] 06:23:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-04-30T06:23:31.032Z] 06:23:31     INFO - GECKO(1054) | [WARN  webrender::renderer::init] asking to enable_gpu_markers but no supporting extension was found
[task 2024-04-30T06:23:31.033Z] 06:23:31     INFO - select "remove condition"
[task 2024-04-30T06:23:31.035Z] 06:23:31     INFO - Waiting for state change: 
[task 2024-04-30T06:23:31.084Z] 06:23:31     INFO - Finished waiting for state change: 
[task 2024-04-30T06:23:31.088Z] 06:23:31     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-cond-ui-state.js | breakpoint condition removed - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b68f4a14c81
[devtools] Show the conditional/log breakpoint panel in codemirror 6 r=devtools-reviewers,nchevobbe

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6b68f4a14c81