Remove obsolete sanity checking code in nsMsgDBFolder::EndNewOfflineMessage()
Categories
(MailNews Core :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: benc, Assigned: benc)
References
Details
(Whiteboard: [fixed by bug 1958052])
in nsMsgDBFolder::EndNewOfflineMessage() there's a whole bunch of code to detect badly-written messages and mark them as not stored offline if an issue is detected.
It needs to be checked through and removed because:
- it relies on a seekable stream, which will not be the case for 90% of the time.
- the mailstore now does proper rollbacks if a write is aborted (or unfinished).
- it's ad-hoc voodoo.
The reason it needs to be checked through:
I vaguely remember this code being involved in an issue where bad IMAP messages were continuously re-downloaded, causing the mbox to keep growing. So there is a genuine issue to deal with somewhere - making sure aborted imap message downloads don't get marked as "stored offline", but this isn't the place to do it.
Looks like Bug 663761 was the original reason for this code... but there have been more recent tweaks and issues over the years.
|
Assignee | |
Updated•8 months ago
|
|
|
Assignee | |
Comment 1•2 months ago
|
||
Looks like this'll be sorted out by one of the patches in Bug 1958052...
|
|
Assignee | |
Comment 2•2 months ago
|
||
Yup. Fixed by Bug 1958052.
|
||
Updated•1 month ago
|
Description
•