1887789 - [UIA] Expose landmarks

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

We need to expose landmarks to UIA clients. There is the UIA LandmarkType property, but it doesn't support all landmark types. For the ones it doesn't support, we might need to support LocalizedLandmarkType also. 😒

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1887789 part 1: Fixes to Accessible::LandmarkRole.

1. The ARIA role should take precedence over the HTML tag.
2. The ARIA region role should only be conditionally treated as a landmark. Use the Gecko role to determine this.
3. Change some other cases to use the Gecko role instead of directly checking the name for consistency and to avoid duplicated logic.

These fixes are tested in the next patch.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1887789 part 2: Implement the UIA LandmarkType property.

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1887789 part 3: Implement the UIA LocalizedLandmarkType property.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/670a7e6fd98d
part 1: Fixes to Accessible::LandmarkRole. r=morgan
https://hg.mozilla.org/integration/autoland/rev/c39acac075fa
part 2: Implement the UIA LandmarkType property. r=morgan
https://hg.mozilla.org/integration/autoland/rev/7b0ce9557ebf
part 3: Implement the UIA LocalizedLandmarkType property. r=morgan

Comment 5

[Cristian Tuns]

Backed out for causing wpt failures in form-roles.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /wai-aria/role/form-roles.html | form without label - assert_equals: <nav role="form" data-testname="form without label" data-expectedrole="navigation" class="ex">x</nav> expected "navigation" but got "form"

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40a3f122dde0
part 1: Fixes to Accessible::LandmarkRole. r=morgan
https://hg.mozilla.org/integration/autoland/rev/32c5edbdf7b9
part 2: Implement the UIA LandmarkType property. r=morgan
https://hg.mozilla.org/integration/autoland/rev/1f8a1dd2ec36
part 3: Implement the UIA LocalizedLandmarkType property. r=morgan

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/40a3f122dde0
https://hg.mozilla.org/mozilla-central/rev/32c5edbdf7b9
https://hg.mozilla.org/mozilla-central/rev/1f8a1dd2ec36