1887818 - Prevent to call GPUVideoImage::GetAsSourceSurface() in CanvasRenderingContext2D::DrawImage() for RemoteDecoderVideoSubDescriptor::Tnull_t if CanvasTranslator is used

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

GPUVideoImage::GetAsSourceSurface() is heavy weight. It seems better to prevent to call it if CanvasTranslator is used.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1887818 - Prevent to call GPUVideoImage::GetAsSourceSurface() in CanvasRenderingContext2D::DrawImage() for RemoteDecoderVideoSubDescriptor::Tnull_t if CanvasTranslator is used

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5343a8186c58
Prevent to call GPUVideoImage::GetAsSourceSurface() in CanvasRenderingContext2D::DrawImage() for RemoteDecoderVideoSubDescriptor::Tnull_t if CanvasTranslator is used r=gfx-reviewers,lsalzman

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5343a8186c58

Comment 4

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5343a8186c58
Prevent to call GPUVideoImage::GetAsSourceSurface() in
CanvasRenderingContext2D::DrawImage() for
RemoteDecoderVideoSubDescriptor::Tnull_t if CanvasTranslator is used
r=gfx-reviewers,lsalzman

== Change summary for alert #42085 (as of Mon, 01 Apr 2024 18:36:02 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
67%	canvas2dvideo Mean tick time across 100 ticks:	linux1804-64-shippable-qr	e10s fission stylo webgl-ipc webrender	12.36 -> 4.04
67%	canvas2dvideo Mean tick time across 100 ticks:	linux1804-64-qr	e10s fission stylo webgl-ipc webrender	12.39 -> 4.06
67%	canvas2dvideo Mean tick time across 100 ticks:	linux1804-64-qr	e10s fission stylo webgl-ipc webrender	12.21 -> 4.06
66%	canvas2dvideo Mean tick time across 100 ticks:	linux1804-64-shippable-qr	e10s fission stylo webrender	12.05 -> 4.05

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=42085