1887913 - AtomIdent and LocalName are different in Servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Oriol Brufau [:Oriol]]

Gecko has:

pub struct AtomIdent(pub Atom);
pub type LocalName = crate::values::AtomIdent;

Servo has:

pub type AtomIdent = GenericAtomIdent<servo_atoms::AtomStaticSet>;
pub type LocalName = crate::values::GenericAtomIdent<html5ever::LocalNameStaticSet>;

So Gecko sometimes uses AtomIdent instead of LocalName because they are the same, but in Servo the difference matters.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1887913 - AtomIdent and LocalName are different in Servo. r?emilio

In Gecko, LocalName is an alias for AtomIdent.
But in Servo they aren't the same, so these changes are needed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e44076c7eeb
AtomIdent and LocalName are different in Servo. r=emilio

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5e44076c7eeb