1888017 - [wpt-sync] Sync PR 45343 - Revert "webnn: Migrate gemm validation tests to WPTs"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45343 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45343
Details from upstream follow.

Fahad Mansoor <[e-mail]> wrote:

Revert "webnn: Migrate gemm validation tests to WPTs"

This reverts commit a303575cfa0453d68d30ca945fa0c4341272c75a.

Reason for revert: Speculative revert to fix WebKit Win10 builders
sample failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Win10/131326/overview

Original change's description:

webnn: Migrate gemm validation tests to WPTs

This CL adds WPT tests for gemm and removes the unit tests MLGraphBuilderTest.GemmTest and MLGraphTestMojo.GemmTest.

Bug: 327337526, 328026885
Change-Id: If7d11f7cd8069f3dab347b2b3328f67b1a009d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5384098
Reviewed-by: Austin Sullivan \<[e-mail]>
Commit-Queue: Shanxing Mei \<[e-mail]>
Reviewed-by: ningxin hu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1278143}

Bug: 327337526, 328026885
Change-Id: Id3b630ba5a9da1f507d20597c13b046ae16c7508
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5392963
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Fahad Mansoor \<[e-mail]>
Owners-Override: Fahad Mansoor \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1278264}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 45343 applied with additional changes from upstream: 6b40eb3abe8c77ca8d6e5c9ab26ff2c51694ea50, 28c1584f646288c2bb69207efc0524572b9ef5d8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=addb5d93df13e69bc0a9d90544d9a36818f4c185

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
FAIL: 8

Chrome

OK : 2
PASS: 2
FAIL: 6

Safari

OK : 2
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webnn/validation_tests/gemm.https.any.worker.html [wpt.fyi]
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gemm] throw if first input is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)
  • [gemm] throw if second input is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)
  • [gemm] throw if c option is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)
• /webnn/validation_tests/gemm.https.any.html [wpt.fyi]
  • assert_not_equals(navigator.ml, undefined, "ml property is defined on navigator"): FAIL (Chrome: PASS, Safari: FAIL)
  • [gemm] throw if first input is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)
  • [gemm] throw if second input is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)
  • [gemm] throw if c option is from another builder: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a36422843dd
[wpt PR 45343] - Revert "webnn: Migrate gemm validation tests to WPTs", a=testonly
https://hg.mozilla.org/integration/autoland/rev/5cad3fff908c
[wpt PR 45343] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a36422843dd
https://hg.mozilla.org/mozilla-central/rev/5cad3fff908c