Closed Bug 1888044 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45361 - [Invokers] Clean up invokers tests

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45361 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45361
Details from upstream follow.

Keith Cirkel <chromium@keithcirkel.co.uk> wrote:

[Invokers] Clean up invokers tests

This change aims to tidy up the invokers tests to reduce the amount of flakey builds from timeouts due to the amount of tests in each file. It refactors all of the invokers tests to:

  • Use loops for repetitive tests
  • Try to consistently test the aliases of auto, explicit empty ("") vs named.
  • Mark any tests using clickOn as timeout long, to avoid flakiness in CI
  • Split the invalid no-ops, to reduce individual test time.

Bug: 40943183
Change-Id: I066b0a6e06143e562a3b0f4c7c1bbaeb309b68f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5374369
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Keith Cirkel <chromium@keithcirkel.co.uk>
Cr-Commit-Position: refs/heads/main@{#1277818}

PR 45361 applied with additional changes from upstream: 49e8a846d9b1e9778c0cd4bdeb54bd796a5211fc, 1881c1e2fec3b1716f234d9a53204b15caf856ed, 42060952b73d4d25a12149adfdafbfe17c4562b9, 8493a5fe8be2d8039c1bd42f8a75dc2510b52bad
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 13 subtests

Status Summary

Firefox

OK : 12
PASS: 83
FAIL: 96

Chrome

OK : 12
PASS: 179

Safari

OK : 12
PASS: 83
FAIL: 96

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/invokers/idlharness.tentative.html [wpt.fyi]
    • InvokeEvent interface: existence and properties of interface object: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface object length: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface object name: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object's "constructor" property: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: existence and properties of interface prototype object's @@unscopables property: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: attribute invoker: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: attribute action: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent must be primary interface of new InvokeEvent("invoke"): FAIL (Chrome: PASS, Safari: FAIL)
    • Stringification of new InvokeEvent("invoke"): FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: new InvokeEvent("invoke") must inherit property "invoker" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEvent interface: new InvokeEvent("invoke") must inherit property "action" with the proper type: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invokeelement-interface.tentative.html [wpt.fyi]
    • invokeTargetElement reflects invokee HTML element: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeTargetElement reflects set value: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeTargetElement reflects set value across shadow root into light dom: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeTargetElement does not reflect set value inside shadowroot: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeTargetElement throws error on assignment of non Element: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects '' when attribute not present: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects '' when attribute empty, setAttribute version: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects same casing: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects tostring value: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects '' when attribute set to []: FAIL (Chrome: PASS, Safari: FAIL)
    • invokeAction reflects tostring value 2: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invokeevent-dispatch-shadow.tentative.html [wpt.fyi]
    • InvokeEvent propagates across shadow boundaries retargeting invoker: FAIL (Chrome: PASS, Safari: FAIL)
    • cross shadow InvokeEvent retargets invoker to host element: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invokeevent-interface.tentative.html [wpt.fyi]
    • action is a readonly defaulting to '': FAIL (Chrome: PASS, Safari: FAIL)
    • invoker is readonly defaulting to null: FAIL (Chrome: PASS, Safari: FAIL)
    • action reflects initialized attribute: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to undefined: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to null: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to false: FAIL (Chrome: PASS, Safari: FAIL)
    • action explicitly set to empty string: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to true: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to a number: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to []: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to [1, 2, 3]: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to an object: FAIL (Chrome: PASS, Safari: FAIL)
    • action set to an object with a toString function: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEventInit properties set value: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEventInit properties set value 2: FAIL (Chrome: PASS, Safari: FAIL)
    • InvokeEventInit properties set value 3: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to undefined: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to null: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to false: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to true: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to {}: FAIL (Chrome: PASS, Safari: FAIL)
    • invoker set to non-Element EventTarget: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-button-event-dispatch.tentative.html [wpt.fyi]
    • event dispatches on click: FAIL (Chrome: PASS, Safari: FAIL)
    • event action is set to invokeAction: FAIL (Chrome: PASS, Safari: FAIL)
    • event action is set to invokeaction attribute: FAIL (Chrome: PASS, Safari: FAIL)
    • event dispatches if invokee is non-HTML Element: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html [wpt.fyi]
    • invoking audio with playpause action makes audio play: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking audio with playpause action (without user activation) is a no-op: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking playing audio with playpause action pauses it: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking audio with play action makes audio play: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking audio with play action (without user activation) is a no-op: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking playing audio with pause action makes it pause: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking audio with toggleMuted action mutes it: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking muted audio with toggleMuted action unmutes it: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-details-behavior.tentative.html [wpt.fyi]
    • invoking (as auto) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as explicit empty) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as toggle) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as open) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as tOgGlE) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as oPeN) closed details opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as auto) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as explicit empty) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as toggle) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as close) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as tOgGlE) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as cLoSe) open details closes: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-popover-behavior.tentative.html [wpt.fyi]
    • changing invokeaction attribute inside invokeevent doesn't impact the invocation: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as auto) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as explicit empty) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as togglepopover) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as showpopover) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as tOgGlEpOpOvEr) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as sHoWpOpOvEr) closed popover opens: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as auto) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as explicit empty) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as togglepopover) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as hidepopover) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as tOgGlEpOpOvEr) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as hIdEpOpOvEr) from within open popover closes: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as showpopover) open popover is noop: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-popover-invalid-behavior.tentative.html [wpt.fyi]
    • invoking (as foo-bar) on open popover does nothing: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as showmodal) on open popover does nothing: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as showpicker) on open popover does nothing: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as open) on open popover does nothing: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking (as close) on open popover does nothing: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/invokers/invoketarget-on-video-behavior.tentative.html [wpt.fyi]
    • invoking video with playpause action makes video play: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking playing video with playpause action pauses it: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking video with play action makes video play: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking playing video with pause action makes it pause: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking video with toggleMuted action mutes it: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking muted video with toggleMuted action unmutes it: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cbbb957a8a27 [wpt PR 45361] - [Invokers] Clean up invokers tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/3f22f0f78ada [wpt PR 45361] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cbbb957a8a27
https://hg.mozilla.org/mozilla-central/rev/3f22f0f78ada

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.