1888045 - [wpt-sync] Sync PR 45359 - [FedCM] Don't call fedcm_get_and_select_first_account when we don't expect an account chooser

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45359 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45359
Details from upstream follow.

Christian Biesinger <[e-mail]> wrote:

[FedCM] Don't call fedcm_get_and_select_first_account when we don't expect an account chooser

Calling this is pointless, and also triggers a Chromedriver bug
(https://crrev.com/c/5398379)

R=[e-mail]

Bug: 331237776
Change-Id: Iae58e8d15dc12851440b1a7edbfd4a579f24300b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5398800
Reviewed-by: Nicolás Peña \<[e-mail]>
Commit-Queue: Nicolás Peña \<[e-mail]>
Auto-Submit: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1278606}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a84d0fdffb29bf6b5a94440a03d26006999cd3f3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

TIMEOUT: 4
NOTRUN : 5

Chrome

PASS : 2
TIMEOUT: 4
NOTRUN : 3

Safari

TIMEOUT: 2
ERROR : 2
NOTRUN : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-domainhint.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • No domain hint matches an account.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • Domain hint matches an account.: NOTRUN (Chrome: TIMEOUT, Safari: NOTRUN)
  • Domain hint matches an account from two accounts.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • Domain hint 'any' matches an account with any domain hint.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
• /credential-management/fedcm-loginhint.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • No login hint matches an account.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • Login hint matches an account.: NOTRUN (Chrome: TIMEOUT, Safari: NOTRUN)
  • Login hint matches an account from two accounts.: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-domainhint.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
• /credential-management/fedcm-loginhint.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/971642e76416
[wpt PR 45359] - [FedCM] Don't call fedcm_get_and_select_first_account when we don't expect an account chooser, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/971642e76416