1888067 - [wpt-sync] Sync PR 45357 - peerconnection: Fire data channel events synchronously

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45357 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45357
Details from upstream follow.

Florent Castelli <[e-mail]> wrote:

peerconnection: Fire data channel events synchronously

When message events are dispatched asynchronously, it is possible to
receive some of those after the state change events are dispatched.
This causes some messages to disappear when a data channel is closing.

Tests are added to verify that all messages sent are received properly
by the remote side as mandated by the specification.

Bug: chromium:40072842
Change-Id: I196cd5b6cae4ea443369b2d9bc98dad474162b23

Reviewed-on: https://chromium-review.googlesource.com/5397720
WPT-Export-Revision: a1130a786b14d3c92d6fd6bf9d14537dec682eba

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed74173136a244afa5f0113d239c87aa3d2fc8a6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
CRASH : 1
FAIL : 3[GitHub] 6[Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug]
TIMEOUT: 1[Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt] 2[GitHub]
NOTRUN : 2

Chrome

OK : 1
FAIL : 6

Safari

TIMEOUT: 2
NOTRUN : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

• /webrtc/RTCDataChannel-send-close.html [wpt.fyi]: CRASH [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt], OK [Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub]

New Tests That Don't Pass

• /webrtc/RTCDataChannel-send-close.html [wpt.fyi]: CRASH [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt], OK [Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [Gecko-linux1804-64-qr-opt, Gecko-windows11-64-2009-qr-opt, GitHub] (Chrome: OK, Safari: TIMEOUT)
  • Datachannel should be able to send and receive all string messages on close: FAIL (Chrome: FAIL, Safari: TIMEOUT)
  • Datachannel should be able to send and receive all arraybuffer messages on close: FAIL (Chrome: FAIL, Safari: NOTRUN)
  • Datachannel should be able to send and receive all blob messages on close: FAIL (Chrome: FAIL, Safari: NOTRUN)
  • Negotiated datachannel should be able to send and receive all string messages on close: FAIL [Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug], TIMEOUT [GitHub] (Chrome: FAIL, Safari: NOTRUN)
  • Negotiated datachannel should be able to send and receive all arraybuffer messages on close: FAIL [Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug], NOTRUN [GitHub] (Chrome: FAIL, Safari: NOTRUN)
  • Negotiated datachannel should be able to send and receive all blob messages on close: FAIL [Gecko-linux1804-64-qr-debug, Gecko-windows11-64-2009-qr-debug], NOTRUN [GitHub] (Chrome: FAIL, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0f4d38ff371
[wpt PR 45357] - peerconnection: Fire data channel events synchronously, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2111da1f7d60
[wpt PR 45357] - Update wpt metadata, a=testonly

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e0f4d38ff371
https://hg.mozilla.org/mozilla-central/rev/2111da1f7d60