Closed Bug 1888163 Opened 8 months ago Closed 7 months ago

Speedup configure clangd backend

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(firefox126 fixed)

Status:
RESOLVED FIXED
Milestone:
126 Branch
Tracking Flags:
Tracking Status
firefox126 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1888163 - Improve quoting in clangd configure backend r=glandium
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

This saves more than 1s in the configure step. I've added a temporary assert to
check that it's equivalent and it indeed is.

Attachment #9393538 - Attachment description: Bug 1888163 - Use shlex.join instead of manual quoting in clangd configure backend r=glandium → Bug 1888163 - Improve quoting in clangd configure backend r=glandium
Attachment #9393538 - Attachment description: Bug 1888163 - Improve quoting in clangd configure backend r=glandium → Bug 1888163 - Improve quoting in clangd configure backend r=glandium!
Attachment #9393538 - Attachment description: Bug 1888163 - Improve quoting in clangd configure backend r=glandium! → Bug 1888163 - Improve quoting in clangd configure backend r=glandium
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/415a4c164027 Improve quoting in clangd configure backend r=glandium

https://hg.mozilla.org/mozilla-central/rev/415a4c164027

Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox126: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: