1888305 - Crash in [@ mozilla::loader::ImportESModule]

Status: RESOLVED DUPLICATE of bug 1716849

(Core :: XPConnect, defect)

Description

[BugBot [:suhaib / :marco/ :calixte]]

Crash report: https://crash-stats.mozilla.org/report/index/8f68e9e4-20ee-4893-b10e-4dcbb0240326

MOZ_CRASH Reason: Failed to load critical module "resource://gre/modules/ExtensionProcessScript.sys.mjs"

Top 10 frames of crashing thread:

0  xul.dll  MOZ_Crash  mfbt/Assertions.h:301
0  xul.dll  mozilla::loader::ImportESModule  js/xpconnect/loader/nsImportModule.cpp:60
1  xul.dll  nsImportESModule::operator const  js/xpconnect/loader/nsImportModule.h:38
1  xul.dll  nsCOMPtr<mozIExtensionProcessScript>::assign_from_helper  xpcom/base/nsCOMPtr.h:901
1  xul.dll  nsCOMPtr<mozIExtensionProcessScript>::operator=  xpcom/base/nsCOMPtr.h:678
1  xul.dll  mozilla::ExtensionPolicyService::ProcessScript  toolkit/components/extensions/ExtensionPolicyService.cpp:82
2  xul.dll  mozilla::ExtensionPolicyService::CheckContentScripts  toolkit/components/extensions/ExtensionPolicyService.cpp:567
3  xul.dll  mozilla::ExtensionPolicyService::CheckDocument  toolkit/components/extensions/ExtensionPolicyService.cpp:521
3  xul.dll  mozilla::ExtensionPolicyService::Observe  toolkit/components/extensions/ExtensionPolicyService.cpp:307
4  xul.dll  nsObserverList::NotifyObservers  xpcom/ds/nsObserverList.cpp:71

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-03-13
• Process type: Content
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - 1 out of 171 crashes happened on null or near null memory address

By analyzing the backtrace, the regression may have been introduced by a patch to fix Bug 1884496.

:standard8, since you are the author of the potential regressor, could you please take a look?

Comment 1

[Mark Banner (:standard8)]

I don't understand why this would cause a crash when the basic change was to import the module directly via ES modules. Forwarding onto :arai to take a look.

Comment 2

[Tooru Fujisawa [:arai]]

This should just be a signature change.
there are many crash reports for the previous function mozilla::loader::ImportModule.
https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3Aloader%3A%3AImportModule&date=%3E%3D2024-03-26T13%3A00%3A00.000Z&date=%3C2024-04-02T13%3A00%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#summary

so, this is a variant of bug 1724000, which is duped to bug 1716849.