1888321 - warning: `$objdir/.cargo/config` is deprecated in favor of `config.toml`

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

This appears during the build with rust nightly:

warning: `$objdir/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`

It's not clear exactly when support for .cargo/config might go away, but the sooner we switch to config.toml, the better.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1888321 - Rename .cargo/config.in to .cargo/config.toml.in.

Cargo 1.79 is emitting a warning when using .cargo/config.
.cargo/config.toml has been supported since cargo 1.39.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5468eadbcdf
Rename .cargo/config.in to .cargo/config.toml.in. r=firefox-build-system-reviewers,webdriver-reviewers,ahochheiden

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d5468eadbcdf

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1888321 - Followup: properly refresh .cargo/config.toml.in when vendoring.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/058016a25503
Followup: properly refresh .cargo/config.toml.in when vendoring. r=firefox-build-system-reviewers,ahochheiden

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/058016a25503

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Now the build causes warning about having both .cargo/config and .cargo/config.toml, probably because the previous .cargo/config is still in the obj dir. Should we try to remove it?

Comment 9

[Mike Hommey [:glandium]]

(In reply to Kagami [:saschanaz] (they/them) from comment #8)

Now the build causes warning about having both .cargo/config and .cargo/config.toml, probably because the previous .cargo/config is still in the obj dir. Should we try to remove it?

Please open a followup bug about it, with the exact warning.