Closed Bug 1888326 Opened 2 years ago Closed 2 years ago

SplitRun() doesn't advance the index after committing a region of memory

Categories

(Core :: Memory Allocator, defect, P1)

defect

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox124 --- unaffected
firefox125 --- unaffected
firefox126 --- fixed

People

(Reporter: pbone, Assigned: pbone)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I noticed that when I updated SplitRun in Bug 1857841 I didn't advance the index within the chunk after committing memory. This causes mozjemalloc to re-check page bits unnecessarily. This doesn't cause any correctness problems but it is less efficient.

Set release status flags based on info from the regressing bug 1857841

Pushed by pbone@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eac0954fe037 Advance the chunk index after committing pages r=glandium
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: