Closed Bug 1888486 Opened 1 year ago Closed 1 month ago

browser.i18n.getPreferredSystemLanguages()

Categories

(WebExtensions :: General, enhancement, P5)

Product:
WebExtensions
Component:
General
Type:
enhancement

Tracking

(firefox141 fixed)

Status:
RESOLVED FIXED
Milestone:
141 Branch
Tracking Flags:
Tracking Status
firefox141 --- fixed

People

(Reporter: carlos-mozilla, Assigned: carlos-mozilla)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [wecg])

Attachments

(1 file, 8 obsolete files)

Bug 1888486 - Implement i18n.getPreferredSystemLanguages r=robwu
48 bytes, text/x-phabricator-request
Details | Review

Add an API to get the UI Language of the Operating System.

See also the related WECG:
https://github.com/w3c/webextensions/pull/569

Attached patch getOSLanguage.patch (obsolete) — — Splinter Review
Assignee: nobody → carlos
Attached patch getOSLanguage.patch (obsolete) — — Splinter Review
Attached patch getOSLanguage.patch (obsolete) — — Splinter Review
Attachment #9393839 - Attachment is obsolete: true
Attachment #9393851 - Attachment is obsolete: true
OS: Unspecified → All
Hardware: Unspecified → All

Please have a look at How to submit a patch.

Flags: needinfo?(carlos)
Attachment #9393852 - Attachment is obsolete: true
Flags: needinfo?(carlos)

Could you squash all patches together? There is no clear reason for patch 1 and 2 being separate. Tests are often in the same patch, except when there are reasons for separating them.

Here is a wiki page that describes contributing to extension code: https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Component: Experiments → General
See Also: → https://github.com/w3c/webextensions/pull/569
Whiteboard: [wecg]
Attachment #9393870 - Attachment description: WIP: Bug 1888486 - Add tests for i18n.getOSLanguage → WIP: Bug 1888486 - Squashed commit of the following:
Attachment #9393870 - Attachment description: WIP: Bug 1888486 - Squashed commit of the following: → WIP: Bug 1888486 - Implement getOSLanguage r=robwu
Attachment #9393869 - Attachment is obsolete: true
Attachment #9393868 - Attachment is obsolete: true
Attachment #9393870 - Attachment description: WIP: Bug 1888486 - Implement getOSLanguage r=robwu → Bug 1888486 - Implement getOSLanguage r=robwu

API design discussions are still happening at https://github.com/w3c/webextensions/issues/252 and https://github.com/w3c/webextensions/pull/569

I will wait for the completion of this API design process before resuming code review.

See Also: → https://github.com/w3c/webextensions/issues/252
Severity: -- → N/A
Priority: -- → P5
Summary: browser.i18n.getOSLanguage() → browser.i18n.getPreferredSystemLanguages()
Attachment #9393870 - Attachment description: Bug 1888486 - Implement getOSLanguage r=robwu → Bug 1888486 - Implement getPreferredSystemLanguages r=robwu
Attachment #9393870 - Attachment description: Bug 1888486 - Implement getPreferredSystemLanguages r=robwu → Bug 1888486 - Implement getOSLanguage r=robwu
Attachment #9393869 - Attachment description: WIP: Bug 1888486 - Implement browser.i18n.getOSLanguage() → WIP: Bug 1888486 - Implement browser.i18n.getPreferredSystemLanguages()
Attachment #9393870 - Attachment description: Bug 1888486 - Implement getOSLanguage r=robwu → Bug 1888486 - Implement i18n.getPreferredSystemLanguages r=robwu
Attachment #9436187 - Attachment is obsolete: true
Attachment #9494405 - Attachment is obsolete: true
Attachment #9494396 - Attachment is obsolete: true
Keywords: dev-doc-needed

https://hg.mozilla.org/mozilla-central/rev/4727114230ed

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox141: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 141 Branch
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: