Closed Bug 1888491 Opened 1 month ago Closed 26 days ago

Create a debugging / developer chrome:// page for backup

Categories

(Firefox :: Profile Backup, task, P1)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-device-migration])

Attachments

(1 file)

This page will make it easier for us to manually test the feature. This is meant to make development easier, and is never meant to be exposed to users, and therefore doesn't require Fluent, a11y review, design etc. It doesn't need an entry point in any existing UI. It doesn't need to run in a content process. I don't think it needs to be an about: page - a chrome URI is probably fine.

A few things this page should do for now:

  1. Be able to kick off the createBackup process
  2. Open the backups folder in a native file explorer

Eventually, when restore functionality starts getting built out, we'll probably want it to be able to rename a backup folder under backups/ to backups/recover and then recover from it, but we'll get there when we get there.

Assignee: nobody → mconley
Priority: P3 → P1

Currently this only gets packaged for Nightly builds. You can access the page
by visiting chrome://browser/content/backups/debug.html.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f90991ecf54d
Build a simple debug interface for BackupService. r=backup-reviewers,kpatenio

Backed out for causing NightlyAsRelease instr bustage.

[task 2024-04-02T21:18:38.065Z] 21:18:38     INFO -  Creating config.status
[task 2024-04-02T21:18:38.296Z] 21:18:38     INFO -  Reticulating splines...
[task 2024-04-02T21:18:44.399Z] 21:18:44    ERROR -  Traceback (most recent call last):
[task 2024-04-02T21:18:44.399Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 351, in <module>
[task 2024-04-02T21:18:44.399Z] 21:18:44     INFO -      sys.exit(main(sys.argv))
[task 2024-04-02T21:18:44.400Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 176, in main
[task 2024-04-02T21:18:44.400Z] 21:18:44     INFO -      return config_status(config)
[task 2024-04-02T21:18:44.400Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/configure.py", line 300, in config_status
[task 2024-04-02T21:18:44.400Z] 21:18:44     INFO -      return config_status(args=[], **sanitized_config)
[task 2024-04-02T21:18:44.400Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/config_status.py", line 152, in config_status
[task 2024-04-02T21:18:44.401Z] 21:18:44     INFO -      definitions = list(definitions)
[task 2024-04-02T21:18:44.401Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 156, in emit
[task 2024-04-02T21:18:44.401Z] 21:18:44     INFO -      objs = list(emitfn(out))
[task 2024-04-02T21:18:44.401Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1580, in emit_from_context
[task 2024-04-02T21:18:44.401Z] 21:18:44     INFO -      for obj in self._process_jar_manifests(context):
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/emitter.py", line 1912, in _process_jar_manifests
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -      raise SandboxValidationError(
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -  mozbuild.frontend.reader.SandboxValidationError:
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -  ==============================
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -  FATAL ERROR PROCESSING MOZBUILD FILE
[task 2024-04-02T21:18:44.402Z] 21:18:44     INFO -  ==============================
[task 2024-04-02T21:18:44.403Z] 21:18:44     INFO -  The error occurred while processing the following file or one of the files it includes:
[task 2024-04-02T21:18:44.403Z] 21:18:44     INFO -      /builds/worker/checkouts/gecko/browser/components/backup/moz.build
[task 2024-04-02T21:18:44.403Z] 21:18:44     INFO -  The error occurred when validating the result of the execution. The reported error is:
[task 2024-04-02T21:18:44.403Z] 21:18:44     INFO -      A jar.mn exists but it is not referenced in the moz.build file. Please define JAR_MANIFESTS.
[task 2024-04-02T21:18:45.241Z] 21:18:45     INFO -  *** Fix above errors and then restart with "./mach build"
[task 2024-04-02T21:18:45.361Z] 21:18:45     INFO - Return code: 1
[task 2024-04-02T21:18:45.362Z] 21:18:45  WARNING - setting return code to 2
[task 2024-04-02T21:18:45.362Z] 21:18:45    FATAL - 'mach build -v' did not run successfully. Please check log for errors.
[task 2024-04-02T21:18:45.362Z] 21:18:45    FATAL - Running post_fatal callback...
[task 2024-04-02T21:18:45.362Z] 21:18:45    FATAL - Exiting -1
Flags: needinfo?(mconley)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43ca379e9c64
Build a simple debug interface for BackupService. r=backup-reviewers,kpatenio
Flags: needinfo?(mconley)
Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b0bc153555d
Follow-up: add an exception for the debug tool in browser_all_files_referenced.js CLOSED TREE
Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/346ae8000d0b
Fix lint failure. a=test-fix CLOSED TREE

(In reply to Pulsebot from comment #6)

Pushed by smolnar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b0bc153555d
Follow-up: add an exception for the debug tool in
browser_all_files_referenced.js CLOSED TREE

I think this was meant to be a Nightly-only exception, like https://searchfox.org/mozilla-central/rev/8340afd1fb3e7b2727d2efb47df1bd3112db7213/browser/base/content/test/static/browser_all_files_referenced.js#311-317 and this seems likely to fail once 126 will merge to beta.

Flags: needinfo?(mconley)
Regressions: 1889666

Thanks florian, fixing in bug 1889666.

Flags: needinfo?(mconley)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: