Closed Bug 1888573 Opened 2 years ago Closed 2 years ago

[toolbar redesign] refactor navbar param list

Categories

(Firefox for Android :: Toolbar, defect, P3)

Product:
Firefox for Android
Component:
Toolbar
Platform:
All
Android
Type:
defect

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: mavduevskiy, Assigned: gl)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid])

We should not pass browserStore: BrowserStore into NavBar composable, should observe states on a level higher instead.

Assignee: nobody → gl
Status: NEW → ASSIGNED
Blocks: 1862100
Type: task → defect
Priority: -- → P3
Blocks: android-toolbar-redesign
No longer blocks: 1862100
Whiteboard: [fxdroid]

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jboek)
Type: task → defect
Flags: needinfo?(jboek)

The severity field is not set for this bug.
:boek, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jboek)
Type: task → defect
Flags: needinfo?(jboek)
Type: task → defect
Type: enhancement → defect
Type: task → defect
Type: enhancement → defect
Type: task → defect
Type: task → defect
Type: task → defect
Type: task → defect

Gonna close this as INVALID. I think this bug is a bit cursed, but also it might not make sense right now to make a blanket refactor to not pass in the BrowserStore into a Composable.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.