1888585 - importing .eml file appends CRLF (when using maildir)

Status: RESOLVED DUPLICATE of bug 1716651

(MailNews Core :: Backend, defect)

Description

[chrizilla]

steps to reproduce

(for a mail account with message store type = "maildir" (not mbox))

1. drag and drop an .eml file from a file manager into Thunderbird's folder pane
2. navigate the file manager to TB's profile folder\Mail
3. find the newly added .eml file
4. hex-compare the new file (from step 3) with the original file (from step 1)

actual results

The file created in TB's profile folder differs from the original file by an appended CRLF (0D 0A).

expected results

• No CRLF should be appended.
• The file created in TB's profile folder and the original file should be 100% identical.

reiteration / generational loss

Note that a repeat of the steps outlined above (i.e. re-importing the file created in step 3 by dragging/dropping it into TB's folder pane) appends yet another CRLF, so the file grows bigger and bigger in size with each iteration!

relevance

Apart from an unnecessary and unintended alteration of the data, this bug severely complicates file deduplication and incremental/differential backup (since the files are not identical anymore).

[keywords: extra newline, linefeed]

Comment 1

[chrizilla]

I did my best but couldn't find any duplicate.
https://bugzilla.mozilla.org/buglist.cgi?list_id=16964863&o2=regexp&o1=regexp&query_format=advanced&bug_type=defect&f2=short_desc&v2=%28newline%7Clinefeed%7CCRLF%7CCR%20LF%7Cblank%20line%29&f1=short_desc&product=MailNews%20Core&product=MailNews%20Core%20Graveyard&product=Thunderbird&v1=%28add%7Cappend%7Cextra%7Cimport%29

Comment 2

[chrizilla]

Attachment: sample files showing CRLF difference

Comment 3

[Tristan Miller]

I remember similar misbehaviour reported in Bug 1427732, so possibly this bug is a regression, or maybe a case that didn't get accounted for in the fix for Bug 1427732. (That bug is about copying a message from an IMAP folder to a local folder, and this one is about importing a message from a file to a local folder.) If not, then I bet Jonathan might be able to find a true duplicate for this one.

Comment 4

[Alfred Peters [:infofrommozilla]]

dupeme: Bug 1716651 I think.

Comment 5

[Magnus Melin [:mkmelin]]

Thanks Alfred!

Comment 6

[chrizilla]

Magnus, I had read that bug report before, but it's not clear (to me at least) what "copying" means there. Please note:

• I am not copying but importing.
• CRLF (\r\n) is added in my case, whereas bug 1716651 only describes an extra \n.

Are you sure that this is really the exact same problem we are describing ?

Comment 7

[Magnus Melin [:mkmelin]]

Very likely it's the same code involved.
Anyway, check back once it's resolved and if it's really something else then we can reopen.

Comment 8

[chrizilla]

Ok, thank you, Magnus.

As mentioned in comment #6 of bug 1716651, I cannot reproduce the appended CRLF reported here in beta/daily, so hopefully it's fixed.
But another problem (bug 1898635) seems to have crept in instead.