1888627 - Interventions invoke onEngagement twice

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Marco Bonardo [:mak]]

Clicking on an intervention button sends one engagement for the button, then a second one when the panel is closed. The panel closes immediately anyway.
This works fine with some of the other buttons because we handle command events specially.
Though, we could just ensure a session can only be recorded once, that will ensure once an engagement or abandonment happened, we are done.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1888627 - Avoid Address Bar engagement telemetry record() re-entrance. r=adw

If a provider onEngagement method causes the address bar panel to close when
a result is picked, we may record consecutive engagement and abandonment events
for the same search session.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f34dc92a899
Avoid Address Bar engagement telemetry record() re-entrance. r=adw

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5f34dc92a899