1888673 - New Sanitize dialog breaks policy

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[Mike Kaply [:mkaply]]

This breaks enteprise policy.

We have policy related to sanitize on shutdown.

There are seven preferences that control this:

privacy.sanitize.sanitizeOnShutdown
privacy.clearOnShutdown.cache, privacy.clearOnShutdown.cookies, privacy.clearOnShutdown.downloads, privacy.clearOnShutdown.formdata, privacy.clearOnShutdown.history, privacy.clearOnShutdown.sessions, privacy.clearOnShutdown.siteSettings, privacy.clearOnShutdown.offlineApps

And we have policy settings to control them by name:

Cache, Cookies, Download History, Form & Search History, Browsing History, Active Logins, Site Preferences and Offline Website Data.

With the new dialog, there are only four options, and locking the above preferences doesn't impact the dialog at all.

https://mozilla.github.io/policy-templates/#sanitizeonshutdown-selective

Comment 1

[Paul Zühlcke [:pbz]]

Thanks Mike! This looks like something we should address before releasing the new dialog. Harshit, could you take a look please?

We will have to update the policy settings to align with our new prefs. Mike, do we need any kind of migration, or would we just update the code + documentation for enterprise policy? We do migrate the prefs, but I assume that wouldn't affect any policy changes since those set the default pref state. Do you know where the code lives that controls the clear-on-shutdown prefs from the enterprise policy side?

Comment 2

[Paul Zühlcke [:pbz]]

Found the policy code controlling the prefs: https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/enterprisepolicies/Policies.sys.mjs#2016

Looks like we need to do the following:

1. Extend https://searchfox.org/mozilla-central/rev/159929cd10b8fba135c72a497d815ab2dd5a521c/browser/components/enterprisepolicies/Policies.sys.mjs#2016 to also support the new prefs. We should keep support for the old prefs until we remove the old dialog.
2. Support locking of prefs in the new dialog. How does the old dialog behave? Do we just disable the checkboxes?
3. Migration or some form of backwards compatibility for the policy settings? I'm hoping we won't have to do this because it adds more complexity.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1854680

Comment 4

[Paul Zühlcke [:pbz]]

Dialog is Nightly only currently. At least before Bug 1883764 lands.

Comment 5

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1888673 - Add new clearOnShutdown prefs to policy. r?pbz

Comment 6

[Mike Kaply [:mkaply]]

Did we verify the disabling works right in the dialog (and only when loaded from prefs)?

Comment 7

[Paul Zühlcke [:pbz]]

(In reply to Mike Kaply [:mkaply] from comment #6)

Did we verify the disabling works right in the dialog (and only when loaded from prefs)?

Harshit showed me some screenshots of that working yesterday. That's with https://phabricator.services.mozilla.com/D206513

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c7e76efdac6
Add new clearOnShutdown prefs to policy. r=pbz,mkaply

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4c7e76efdac6